handle an edge case in newpayload block execution #3131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
acolytec3
previously requested changes
Oct 31, 2023
| // this error can come if the block tries to load a previous block yet not in the chain | ||
| // error coding of the evm errors should be a better way to handle this | ||
| // | ||
| // at Blockchain.getBlock (/home/gajinder/ethereumjs-monorepo/packages/blockchain/src/blockchain.ts:763:15) |
There was a problem hiding this comment.
Do we need this entire stack trace in the logs?
There was a problem hiding this comment.
if the issue clear can remove the trace
acolytec3
reviewed
Oct 31, 2023
this particular edge case might not be covered ... i think we would need to have a tx that does BLOCKHASH opcode, could add this |
holgerd77
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle an edgecase noticed during holesky sync