Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to Unleashing ETC post #1163

Merged
merged 2 commits into from
Apr 6, 2023
Merged

Fixes to Unleashing ETC post #1163

merged 2 commits into from
Apr 6, 2023

Conversation

IstoraMandiri
Copy link
Collaborator

This PR makes some tweaks to the recent blog post by @TheCrowbill #1162

I understand that you may not have been aware of these particular details, so please don't worry. However, I have a proposed a few changes that I believe could be helpful.

  • rename contributor to contributors to make avatar appear properly
  • remove opinion tag, instead use disclaimer: opinion, see Reorganize tags #1121
  • Convert gif to jpg, although gifs will render, gatsby can only resize/process png/jpegs, so should be used images that aren't animated
  • Add reference to original medium blog at the bottom of the post
  • Format the quote differently

Thank you for the post!

@IstoraMandiri IstoraMandiri requested a review from a team April 6, 2023 01:16
@netlify
Copy link

netlify bot commented Apr 6, 2023

Deploy Preview for ethereumclassic ready!

Name Link
🔨 Latest commit 7d9ce27
🔍 Latest deploy log https://app.netlify.com/sites/ethereumclassic/deploys/642f15c5847428000814ced5
😎 Deploy Preview https://deploy-preview-1163--ethereumclassic.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@TheCrowbill TheCrowbill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @IstoraMandiri. I did not know how to apply most of the style subtleties.

One thing I would like to comment on is the file formatting for the image.

For image processing, I used Adobe Elements. When preparing image files for use on a website, it supposedly analyzes the image then optimizes such things as compression level and resolution, and finally recommends a file format. I've noticed that 99% of the time it recommends .jpeg formatting. For a few images, however, it chooses a .gif format even though the image is not animated. This was one of those oddball images, apparently.

@TheCrowbill TheCrowbill merged commit 5549cf0 into master Apr 6, 2023
@TheCrowbill TheCrowbill deleted the fix-unleashing-blog branch April 6, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants