Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make height adjustment #5401

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

make height adjustment #5401

wants to merge 4 commits into from

Conversation

joeizang
Copy link
Collaborator

@joeizang joeizang commented Nov 13, 2024

fixes #5397

@joeizang joeizang added the ready-to-review PR ready to review label Nov 13, 2024
@joeizang joeizang self-assigned this Nov 13, 2024
Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for remixproject ready!

Name Link
🔨 Latest commit 744e04d
🔍 Latest deploy log https://app.netlify.com/sites/remixproject/deploys/67447e7d3e346f0008d2b5cb
😎 Deploy Preview https://deploy-preview-5401--remixproject.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@pr15il pr15il left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maxHeight should be kept at 40rem and height changed to 67%

@@ -89,10 +89,10 @@ export class PopupPanel extends AbstractPanel {
<div
className={`px-0 bg-light border-info ${appState?.showPopupPanel ? 'd-flex' : 'd-none'}`}
style={{
maxHeight: '40rem',
maxHeight: '60%',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
maxHeight: '60%',
maxHeight: '40rem',

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can even remove max-height

maxWidth: '25rem',
width: 'max-content',
height: '40rem',
height: '60%',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
height: '60%',
height: '67%',

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

80% looks better

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try 

max-height: 40rem;
min-width: 22rem;
width: 25%;
height: 80%;

and the div inside should have width 100%

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok will have a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-review PR ready to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Height of RemixAI UI is not Responsive
4 participants