Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] Circuit compiler actions #5238

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[REFACTOR] Circuit compiler actions #5238

wants to merge 4 commits into from

Conversation

azarpoor
Copy link

  • improve coding structure of circuit compiler actions
  • make it more readable
  • remove some additional codes
  • improve error handling

@netlify Netlify
Copy link

netlify bot commented Sep 30, 2024 •
edited
Loading

👷 Deploy request for remixproject pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit e0c0437

@azarpoor
Copy link
Author

azarpoor commented Sep 30, 2024 •
edited
Loading

@joeizang @yann300

dIvaD8
dIvaD8 reviewed Sep 30, 2024
View reviewed changes
apps/circuit-compiler/src/app/actions/index.ts
Comment on lines -11 to -12
} else {
console.log('Existing circuit compilation in progress')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9 - !==

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey thank you i correct this check

@azarpoor azarpoor requested a review from dIvaD8 October 1, 2024 12:55
@azarpoor
Copy link
Author

azarpoor commented Oct 3, 2024

@bunsenstraat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dIvaD8 dIvaD8 Awaiting requested review from dIvaD8

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azarpoor @dIvaD8