[2/3] Linted file with isort in eth and tests directory #2099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prathmeshranaut
force-pushed
the
prathmeshranaut/add-isort-linted
branch
2 times, most recently
from
6999ad2
to
b57af94
Compare
prathmeshranaut
changed the title
prathmeshranaut
force-pushed
the
prathmeshranaut/add-isort-linted
branch
2 times, most recently
from
f9d16e6
to
ef9b573
Compare
prathmeshranaut
changed the title
prathmeshranaut
force-pushed
the
prathmeshranaut/add-isort-linted
branch
2 times, most recently
from
dfcea1a
to
cbb591d
Compare
prathmeshranaut
changed the title
prathmeshranaut
force-pushed
the
prathmeshranaut/add-isort-linted
branch
3 times, most recently
from
c5625e9
to
e23faf1
Compare
|
@pacrob Rebased with master and is ready for review. |
|
Hey @prathmeshranaut, thanks for moving on this. We're working on a refactor related to #2089, and it'll much easier get that merged then re-lint-roll than the other way around. I'll comment back here when we're ready to apply. Thanks! |
pacrob
force-pushed
the
prathmeshranaut/add-isort-linted
branch
2 times, most recently
from
ffc4e18
to
928cb1f
Compare
pacrob
force-pushed
the
prathmeshranaut/add-isort-linted
branch
from
928cb1f
to
2f421ce
Compare
|
Thanks for your help on this @prathmeshranaut ! I decided to just cherry-pick the "adding isort to tox" commit into this PR and made a couple small tweaks, and it should be ready to go! |
…e for isorting commit
pacrob
force-pushed
the
prathmeshranaut/add-isort-linted
branch
from
19286ad
to
cf14239
Compare
fselmo
approved these changes
May 4, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Imports are not sorted.
Closes Issue #2094
How was it fixed?
Added
isort, a tool to sort imports, in the linting process.Adding lint setup + linting files would be a large PR to review. I've decided to split it up into 3 parts.
First PR
flowchart LR pr1[Added isort to setup, makefile and tox] --> pr2[Linted file with isort in eth and tests directory - This PR] pr2 --> pr3[Add isort check to tox]This is second PR of a two part linting rollout. In this PR, I ran
make lint-roll.In order to validate and review the PR quickly, you can checksum
ethandtestsdirectory.Let me know if I missed anything in the contribution process.
Todo:
Clean up commit history
Add or update documentation related to these changes
Add entry to the release notes
Cute Animal Picture