hivesim: add --sim.limit.exact hive flag #929
Conversation
|
Note you can run a single test by anchoring the regular expression, e.g. |
|
Perfect! Closing in favor of anchoring with regex :D |
|
Ah, we have to use the following: Going to re-open and try to make the usage slightly easier without the escaped characters |
|
Can we see that we try to properly integrate something like this in the Hive documentation (might need some overhaul in general to some extend)? That would be really helpful! 🙂 🙏 |
|
The docs are here: https://github.com/ethereum/hive/blob/master/docs/commandline.md#simulation-options We can definitely add more info about |
Yes, that would be nice. I am not tech-savvy enough to side-read out of the current docs how to run a single test e.g. with this |
|
Is this still a wanted feature? |
|
Will look into adding the relavant information in a future docs overhaul. |
|
I think we could also add this in the hive command only. The 'exact' flag could just escape the regexp and also anchor it. My question was really if you still want this feature at all. |
|
Ah okay, personally yes I do think it is useful to have. I created a new PR here: #969 as I didn't realize force pushing to a branch meant you could not re-open it. |
Description
On occasion we may use a regex pattern that will run more tests than intended.
The intention behind the
sim.limitbelow may be to solely run a single test in isolation:... --sim.limit engine-cancun/"InvalidPayloadAttributes: Missing BeaconRoot" --docker.outputDue to the increasing number of tests within the engine simulator alongside its programtic naming of tests, the above
sim.limitwill run and additional test using regex matching:Proposed Change
Add an additional flag:
--sim.limit.exactthat can be used to specify the exact test to be ran (not using regex). This somewhat acts as an alternatice solution to #914.Work in progress...