chore: Add Gnark Bn254 precompile methods for fuzzing #30585
+268
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
commented
Oct 12, 2024
Comment on lines
+7
to
+11
| // This is just the addition formula | ||
| // but given we know that we do not need Jacobian | ||
| // coordinates, we use the naive implementation. | ||
| // | ||
| // Ideally, we push this into gnark |
There was a problem hiding this comment.
As mentioned, I can remove this file and or upstream to gnark first -- added it as I noticed that most cryptography libraries are not well suited to the usecase where we do an operation on a point and then serialize straight after, most libraries asssume that you are going to make further computations on the result
There was a problem hiding this comment.
I did some rough benchmarks and it looked like this smooths out the variance between the worse cases
kevaundray
commented
Oct 12, 2024
|
running |
|
running BenchmarkPrecompiledBn256Add after change with Option 3: |
|
running BenchmarkPrecompiledBn256Add after change with Option 2: |
|
running BenchmarkPrecompiledBn256Add after change with Option 1: |
|
running BenchmarkPrecompiledBn256ScalarMul before this change: after this change: |
|
running BenchmarkPrecompiledBn256Pairing before this change: after this change: Note: |
|
Could you also add it to the fuzzer already? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the gnark precompile methods so that they can be used as fuzzing and perhaps in the future replace the google variant; I noticed that the google variant looked quite similar to the cloudflare one.