Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/ethapi: Set basefee for AccessList based on given block, not chain tip #30538

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

internal/ethapi: Set basefee for AccessList based on given block, not chain tip #30538

wants to merge 6 commits into from
+13 −5

Commits on Oct 2, 2024

  1. internal/ethapi: set dynamic fee fields to 0 in access list so that s… 

    …etting NoBaseFee will disable subsequent validation
    @jwasinger
    jwasinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    612d281 View commit details
    Browse the repository at this point in the history

  2. try using CallDefaults instead of setDefaults (AccessList is an eth_c… 

    …all-like operation)
    @jwasinger
    jwasinger committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    5fce58e View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. check error from CallDefaults. if tx nonce was not provided, fill it … 

    …from the db
    @jwasinger
    jwasinger committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    6d3b000 View commit details
    Browse the repository at this point in the history

  2. remove print statement

    @jwasinger
    jwasinger committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    5b243e4 View commit details
    Browse the repository at this point in the history

  3. docs

    @jwasinger
    jwasinger committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    599fded View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. ensure AccessList calls setFeeDefaults so that fee fields are filled … 

    …with proper values. modify setFeeDefaults to take a historical header value (doesn't work if EIP-1559 is disabled. everything other than AccessLists, which were introduced after/same-time (?) as 1559, calls setFeeDefaults with current block header.
    @jwasinger
    jwasinger committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    78897ff View commit details
    Browse the repository at this point in the history