feat(eth/tracers): convert OOG wrapped error to Out Of Gas parity error #30497
+115
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
Signed-off-by: jsvisa <[email protected]>
s1na
reviewed
Oct 10, 2024
eth/tracers/internal/tracetest/testdata/call_tracer_flat/callcode_precompiled_throw.json
Show resolved
Hide resolved
s1na
reviewed
Oct 14, 2024
| @@ -54,6 +54,7 @@ var parityErrorMapping = map[string]string{ | |||
| } | |||
|
|
|||
| var parityErrorMappingStartingWith = map[string]string{ | |||
| "out of gas:": "Out of gas", // convert OOG wrapped errors, eg `out of gas: not enough gas for reentrancy sentry` | |||
There was a problem hiding this comment.
Is the casing correct here? Just asking to be sure.
There was a problem hiding this comment.
yes, actually they come from https://github.com/ethereum/go-ethereum/blob/fad7e74a1b/core/vm/interpreter.go#L279-L281
cost += dynamicCost // for tracing
if err != nil {
return nil, fmt.Errorf("%w: %v", ErrOutOfGas, err)
}
s1na
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.