feat: migrate Card to tailwind #14683
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corwintines
requested review from
wackerow,
pettinarip and
minimalsm
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Jan 16, 2025
pettinarip
requested changes
Jan 17, 2025
There was a problem hiding this comment.
@corwintines left a couple of comments related to colors before we move forward with it.
| <div | ||
| className={cn( | ||
| "flex flex-col justify-between space-y-4", | ||
| "rounded-sm bg-ednBackground", |
There was a problem hiding this comment.
Suggested change
| "rounded-sm bg-ednBackground", | |
| "rounded-sm bg-background-highlight", |
| className={cn( | ||
| "flex flex-col justify-between space-y-4", | ||
| "rounded-sm bg-ednBackground", | ||
| "border border-solid border-lightBorder", |
There was a problem hiding this comment.
Suggested change
| "border border-solid border-lightBorder", | |
| "border border-solid border-low-contrast", |
There was a problem hiding this comment.
The changes mentioned before would avoid adding these colors as we don't want to support them anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
src/components/Card/index.tsxfrom Chakra to tailwind