Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shadcn Migration - DocsNav #14039

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Shadcn Migration - DocsNav #14039

merged 5 commits into from
Oct 22, 2024

Conversation

saurabhburade
Copy link
Contributor

Description

Migrate DocsNav to tailwind.

Related Issue

#13946

@netlify Netlify
Copy link

netlify bot commented Oct 3, 2024 •
edited
Loading

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 26f2e05
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/670fa132e9d4cc00080e7571
😎 Deploy Preview https://deploy-preview-14039--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 48 (🔴 down 5 from production)
Accessibility: 93 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@saurabhburade saurabhburade marked this pull request as ready for review October 3, 2024 08:30
@pettinarip pettinarip mentioned this pull request Oct 3, 2024
Open
65 tasks
pettinarip
pettinarip reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saurabhburade great job on this one.

We have added recently the LinkBox and LinkOverlay replacements. Wanted to ask you if you would be interested in implementing them in this PR. Same refactor could be added to your other PR #14036. LMK what do you think.

src/components/DocsNav.tsx Outdated Show resolved Hide resolved
src/components/DocsNav.tsx Outdated Show resolved Hide resolved
@saurabhburade
Copy link
Contributor Author

@saurabhburade great job on this one.

We have added recently the LinkBox and LinkOverlay replacements. Wanted to ask you if you would be interested in implementing them in this PR. Same refactor could be added to your other PR #14036. LMK what do you think.

Yeah, this sounds great. Implementing LinkBox & LinkOverlay

pettinarip
pettinarip approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks @saurabhburade

@pettinarip pettinarip added the hacktoberfest Track hacktoberfest activity label Oct 17, 2024
wackerow
wackerow approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks @saurabhburade

@wackerow wackerow merged commit 5d07a63 into ethereum:dev Oct 22, 2024
9 of 10 checks passed
This was referenced Oct 23, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wackerow wackerow wackerow approved these changes

@pettinarip pettinarip pettinarip approved these changes

@corwintines corwintines Awaiting requested review from corwintines corwintines is a code owner

@minimalsm minimalsm Awaiting requested review from minimalsm minimalsm is a code owner

Assignees
No one assigned
Labels
hacktoberfest Track hacktoberfest activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saurabhburade @pettinarip @wackerow