Migrate layer 2 page to shadcn, and updates for layer 2 migration #13987
Conversation
corwintines
requested review from
wackerow,
pettinarip and
minimalsm
as code owners
❌ Deploy Preview for ethereumorg failed.
|
github-actions
bot
added
content 🖋️
There was a problem hiding this comment.
Nice @corwintines! Lookin good, just dropped an initial round of feedback and thoughts.
public/images/layer-2/learn-hero.png
Outdated
There was a problem hiding this comment.
Noticing this is an image the chops on the top and bottom edges... looks a little strange having padding in the Y-direction here inside the hero cc: @nloureiro
| {titleKey && ( | ||
| <h3 className="mb-8 mt-10 text-2xl leading-[1.4]">{t(titleKey)}</h3> | ||
| )} | ||
| {title && ( | ||
| <h3 className="mb-8 mt-10 text-2xl leading-[1.4]">{title}</h3> | ||
| )} | ||
| {descriptionKey && ( | ||
| <p className="mb-6 text-xl leading-[140%] text-body-medium"> | ||
| {t(descriptionKey)} | ||
| </p> | ||
| )} | ||
| {description && ( | ||
| <p className="mb-6 text-xl leading-[140%] text-body-medium"> | ||
| {description} | ||
| </p> | ||
| )} |
There was a problem hiding this comment.
I'm a little unclear why we're opening up the props to optionally accept title and description or the keys for these:
Is the plan to change these components to not have to handle the translation keys? As-is we no longer have any of the props as required.
| if (path.startsWith("/layer-2/")) { | ||
| primaryNamespace = "page-layer-2" | ||
| } |
There was a problem hiding this comment.
Just noting that as-is the page-layer-2 namespace will be loaded on /layer-2/learn/; is this what we want? If not, I'd change this one to not use startsWith()
| "page-layer-2-learn-meta-title": "What is layer 2", | ||
| "page-layer-2-learn-title": "What is layer 2", | ||
| "page-layer-2-learn-description": "Scaling Ethereum for mass adoption", | ||
| "page-layer-2-learn-button-1-label": "What is layer 2", | ||
| "page-layer-2-learn-button-2-label": "Use layer 2", | ||
| "page-layer-2-learn-what-is-layer-2-title": "What is layer 2?", |
There was a problem hiding this comment.
Seeing 4 instances of "What is layer 2"... one of which has a question mark
- Should we have a question mark at the end of this string? (I think we should)
- Do we need to repeat this key, or can we simplify to just have one instance of "What is layer 2?"
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Co-authored-by: Paul Wackerow <[email protected]>
Description
Migrates layer 2 page to shadcn
Move layer 2 page to /layer-2/learn
Updates for the layer 2 migration to this page
Link: https://deploy-preview-13987--ethereumorg.netlify.app/layer-2/learn