[WIP] Implement BIP32 HD account class #27
Conversation
|
#28 has some thoughts about what the abstract class looks like. I wouldn't recommend subclassing |
|
#29 has a preview of the class that should be subclassed: Edit: you can rebase and subclass |
|
@dilatebrave Are you still working here? Hope you're doing well 🙂 |
|
@vs77bb --- i'm sill working on this but got stuck at signing trans with the extended key. I'm lacking knowledge at this area so it took me sometime to read more |
| BIP32_HARDEN = 0x80000000 # choose from hardened set of child keys | ||
| CURVE_GEN = ecdsa.ecdsa.generator_secp256k1 | ||
| CURVE_ORDER = CURVE_GEN.order() | ||
| EX_MAIN_PRIVATE = [ codecs.decode('0488ade4', 'hex') ] # Version strings for mainnet extended private keys |
There was a problem hiding this comment.
Can you link to a reference for where this magic number comes from?
There was a problem hiding this comment.
These numbers come from the bip https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki
I don't know how to specify the line in that file so please go there and search for the numbers >.<
There was a problem hiding this comment.
https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki#serialization-format <- that link is sufficient, and should go in a source comment
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "python.pythonPath": "${workspaceFolder}/venv/bin/python" | |||
There was a problem hiding this comment.
This looks like something that needs to be removed and added to the .gitignore
There was a problem hiding this comment.
yes, that needs to be removed
| import ecdsa | ||
|
|
||
| from hashlib import sha256 | ||
| from ecdsa.curves import SECP256k1 |
There was a problem hiding this comment.
We prefer to be flexible about what implementation people choose for this sort of thing. We have a library called eth-keys which implements the secp256k1 operations for public/private keys and signatures that I believe is going to be our preferred way to do this.
However, I'm not entirely sure it will do everything that you need for HD keys so I'm interested in your feedback on what is missing/needed if that is the case.
There was a problem hiding this comment.
i didn't know about that library. i will try it out ^^
|
Hi @dilatebrave mind responding to comments back here? |
|
@vs77bb --- thanks for notifying me |
|
@dilatebrave no apologies necessary. Thank you for taking this on. |
Skip venv in template filler & print progress
What was wrong?
Issue #24
How was it fixed?
Cute Animal Picture