-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new abstract base class for LocalAccount #28
Comments
This was referenced Jun 7, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With the incoming work on #25 (in PR #26) -- it's time to have an abstract class defining the interface for a
LocalAccount
, plus some docs about which methods must be implemented. Specifically:address
property is requiredsignHash()
is requiredsignTransaction()
is required__hash__()
and__eq__()
are required - so care should be taken that the account cannot be mutated to use a different private key.privateKey
property is optional, since some sources refuse to reveal it (like a hardware wallet)encrypt()
is optional, since some accounts cannot reveal the private key(Also, I just noticed that the docs for
encrypt
inLocalAccount
are wrong. See the definition inAccount
insteadThe text was updated successfully, but these errors were encountered: