Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

landakram's solhint revisions applied #93

Closed
wants to merge 5 commits into from

Conversation

GokhanPolat
Copy link

Ethlint (formerly Solium) package has a bug about the call function. So I decide to use solhint.
I just merged landakram's solhint implementation to master branch and correct some typos from here and here.

With this implementation solc can work with both linters or only selected one.

@landakram
Copy link
Contributor

landakram commented Oct 19, 2022

Hey, thanks for picking this back up. Unfortunately the fix for changing solhint formatter from visualstudio to unix isn't so easy, and I don't think what you have would work as is: the flycheck error patterns must also be changed to match the unix format. However, you motivated me to figure out the right pattern and fix up my PR, which I've done here: d3901a3

@GokhanPolat
Copy link
Author

I noticed just now. Repo updated and flycheck errors looks more accurate, thanks @landakram.

BTW new errors;
Screen Shot 2022-10-19 at 20 04 49

and old one;
Screen Shot 2022-10-19 at 18 54 19

@landakram
Copy link
Contributor

Glad the changes work for you! Since I fixed the issues in my PR #75, is this PR a duplicate? If so, it might make sense to close this one and merge the original (which has some useful commit messages)

@hrkrshnn
Copy link
Member

@landakram would you be able to review this PR? I can merge it afterwards

@GokhanPolat
Copy link
Author

Glad the changes work for you! Since I fixed the issues in my PR #75, is this PR a duplicate? If so, it might make sense to close this one and merge the original (which has some useful commit messages)

Yes, I combined exactly yours code and master branch of this repo. I can happily to close this PR. =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants