Move yield pre-state after pre-state setup

[jtraglia]

This PR fixes two incorrect tests which were new to the alpha.7 release:

• basic_el_withdrawal_request
• cl_exit_and_el_withdrawal_request_in_same_block

The problem: we call set_eth1_withdrawal_credential_with_balance after yield 'pre', state, so the expected pre-state is incorrect. This also explains why the tests pass locally but not for the clients.

The solution: move the yield 'pre', state statement after changes to the pre-state. For consistency, I moved the yield statement for all four functions in this file, so they are all in the same relative spot.

Thank you @hwwhww for identifying the problem.

See also:

• Investigate failures with EL withdrawal requests sanity blocks ref tests Consensys/teku#8680

[hwwhww]

Thank you @jtraglia !

And thank @tersec @terencechain @lucassaldanha for reporting it!

[ralexstokes]

lgtm!