Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move standard checks to "Fault Proofs only" model #383

Merged
merged 17 commits into from
Jul 15, 2024
Merged

Move standard checks to "Fault Proofs only" model #383

merged 17 commits into from
Jul 15, 2024

Conversation

geoknee
Copy link
Collaborator

@geoknee geoknee commented Jul 11, 2024 •
edited
Loading

We currently support both MCP and Fault Proof contract version sets in the superchain registry standard validation checks. However, it has now become clear that Fault Proofs is a hard requirement for a chain to become standard. Therefore this PR cleans up and removes support for pre fault proof chains.

Related issue ethereum-optimism/specs#276

Changes:

  • Remove MCP from list of acceptable contract versions for standard chains
  • Excludes legacy standard candidate chains from contract version checks
  • removes contract version tag from config files, this is no longer needed
  • removes L2OO based tests
  • adds Rollup Config tests, including for the block time (previously looked up on chain, this is actually an off chain parameter)
  • adds OptimismPortal2 based tests

https://specs.optimism.io/protocol/configurability.html?highlight=op%20stack#consensus-parameters

Closes #333

@geoknee geoknee requested a review from a team as a code owner July 11, 2024 16:56
@geoknee geoknee requested a review from tynes July 11, 2024 16:56
@geoknee geoknee changed the title remove MCP as supported contract version for standard chains Remove MCP as supported contract version for standard chains Jul 11, 2024
@geoknee geoknee marked this pull request as draft July 11, 2024 17:19
@geoknee geoknee marked this pull request as ready for review July 11, 2024 17:22
@geoknee geoknee changed the title Remove MCP as supported contract version for standard chains Move standard checks to "Fault Proofs only" model Jul 11, 2024
@geoknee geoknee marked this pull request as draft July 11, 2024 17:27
@geoknee geoknee mentioned this pull request Jul 12, 2024
Merged
geoknee added 10 commits July 13, 2024 23:11
@geoknee
remove MCP as supported contract version for standard chains
1c1085f 
exclude legacy standard candidate chains
@geoknee
remove "contract_versions_tag" and l2OO tests
7a6e7e3 
we now require fault proof contracts, the l2OO is deprecated on FP chains
@geoknee
remove unused helper
a60e205
@geoknee
remove l2oo.submission_interval and l2oo.challenge_period_seconds
3cf36fb 
See ethereum-optimism/specs#253

Move l2_block_time to rollup_config section
@geoknee
replace data availability test with more general rollup config test
765b6af
@geoknee
track and validate l2_block_time
f865c18 
ethereum-optimism/specs#276
@geoknee
update existing chain configs to store block_time = 2
06135ae 
this is actually not properly configurable, yet since op-node will just ignore / overwrite this value
@geoknee
track and validate sequencing window
41aae2c 
Closes #374
@geoknee
add OptimismPortal2 stamdard params and validation check
39d5aa6
@geoknee
fix bugs
149bcad
@geoknee geoknee marked this pull request as ready for review July 13, 2024 22:22
sebastianst
sebastianst reviewed Jul 15, 2024
View reviewed changes
Copy link
Member

@sebastianst sebastianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it planned to run validations against the DisputeGameFactory?

validation/exclusions_test.go Outdated Show resolved Hide resolved
validation/exclusions_test.go Outdated Show resolved Hide resolved
validation/exclusions_test.go Outdated Show resolved Hide resolved
validation/exclusions_test.go Outdated Show resolved Hide resolved
validation/optimism-portal-2-params_test.go Outdated Show resolved Hide resolved
validation/standard/standard-config-params-sepolia-dev-0.toml Outdated Show resolved Hide resolved
validation/superchain-version_test.go Outdated Show resolved Hide resolved
@geoknee geoknee mentioned this pull request Jul 15, 2024
Merged
@geoknee
Copy link
Collaborator Author

geoknee commented Jul 15, 2024

Is it planned to run validations against the DisputeGameFactory?

We don't have anything in the standard config specs for this, so I don't think it is in scope at the moment.

@sebastianst sebastianst merged commit 2940d5e into main Jul 15, 2024
18 checks passed
@sebastianst sebastianst deleted the gk/remove-mcp branch July 15, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastianst sebastianst sebastianst approved these changes

@tynes tynes Awaiting requested review from tynes tynes was automatically assigned from ethereum-optimism/go-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove MCP contract tag from standard-versions.toml and exclude legacy standard candidate chains
2 participants
@geoknee @sebastianst