-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sep/026: Add task to fix sepolia fp upgrade #421
Merged
Merged
+288
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastianst
force-pushed
the
seb/sep-025-fp-fix
branch
from
December 17, 2024 20:50
5322598
to
0e47db0
Compare
sebastianst
commented
Dec 17, 2024
sebastianst
commented
Dec 17, 2024
fyi the 025 task number is used and now executed by #410 |
mds1
reviewed
Dec 18, 2024
mds1
reviewed
Dec 18, 2024
sebastianst
force-pushed
the
seb/sep-025-fp-fix
branch
from
December 18, 2024 10:21
0e47db0
to
4687d2b
Compare
sebastianst
changed the title
sep/025: Add task to fix sepolia fp upgrade
sep/026: Add task to fix sepolia fp upgrade
Dec 18, 2024
sebastianst
changed the title
sep/026: Add task to fix sepolia fp upgrade
sep/026: Add validation framework & task to fix sepolia fp upgrade
Dec 18, 2024
Ethnical
reviewed
Dec 18, 2024
sebastianst
force-pushed
the
seb/sep-025-fp-fix
branch
from
December 18, 2024 14:55
3141303
to
7a83426
Compare
mds1
reviewed
Dec 18, 2024
mds1
reviewed
Dec 18, 2024
mds1
previously approved these changes
Dec 18, 2024
Ethnical
reviewed
Dec 19, 2024
Ethnical
reviewed
Dec 19, 2024
Ethnical
reviewed
Dec 19, 2024
sebastianst
added a commit
that referenced
this pull request
Dec 19, 2024
Developed in #421 and now split into its own PR.
Inphi
previously approved these changes
Dec 20, 2024
This was referenced Dec 20, 2024
sebastianst
force-pushed
the
seb/sep-025-fp-fix
branch
from
December 20, 2024 18:02
98b9fa0
to
28e82b3
Compare
sebastianst
force-pushed
the
seb/sep-025-fp-fix
branch
2 times, most recently
from
January 6, 2025 11:32
e319959
to
8e8068b
Compare
auto-merge was automatically disabled
January 6, 2025 11:36
Merge commits are not allowed on this repository
Ethnical
reviewed
Jan 7, 2025
Ethnical
reviewed
Jan 7, 2025
Ethnical
reviewed
Jan 7, 2025
Ethnical
reviewed
Jan 7, 2025
Ethnical
reviewed
Jan 7, 2025
Ethnical
reviewed
Jan 7, 2025
Ethnical
reviewed
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! We need to fix the validation file before once this is done we can merge directly!
Sorry for the delay!
sebastianst
force-pushed
the
seb/sep-025-fp-fix
branch
from
January 9, 2025 19:21
8e8068b
to
8d77355
Compare
Ethnical
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds task to fix the Sepolia FP upgrade, since the old one (#374) referenced a wrongly newly deployed
DelayedWETH
implementation.Also adds a framework for creating reusable verification scripts.The framework was split into its own PR with #429Additional context
This task may actually be obsolete because of #410update: it's necessary because #410 reused the wrongDelayedWETH
s.Based on #442 which adds additional checks to DG upgrades.
Metadata
Towards ethereum-optimism/optimism#13033