Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sep/026: Add task to fix sepolia fp upgrade #421

Merged
merged 5 commits into from
Jan 9, 2025
Merged

Conversation

sebastianst
Copy link
Member

@sebastianst sebastianst commented Dec 17, 2024

Description

Adds task to fix the Sepolia FP upgrade, since the old one (#374) referenced a wrongly newly deployed DelayedWETH implementation.

Also adds a framework for creating reusable verification scripts. The framework was split into its own PR with #429

Additional context

This task may actually be obsolete because of #410 update: it's necessary because #410 reused the wrong DelayedWETHs.

Based on #442 which adds additional checks to DG upgrades.

Metadata

Towards ethereum-optimism/optimism#13033

justfile Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@Inphi
Copy link
Contributor

Inphi commented Dec 17, 2024

fyi the 025 task number is used and now executed by #410

@sebastianst sebastianst changed the title sep/025: Add task to fix sepolia fp upgrade sep/026: Add task to fix sepolia fp upgrade Dec 18, 2024
@sebastianst sebastianst changed the title sep/026: Add task to fix sepolia fp upgrade sep/026: Add validation framework & task to fix sepolia fp upgrade Dec 18, 2024
@sebastianst sebastianst marked this pull request as ready for review December 18, 2024 14:11
@sebastianst sebastianst requested review from a team as code owners December 18, 2024 14:11
.circleci/config.yml Outdated Show resolved Hide resolved
NESTED-VALIDATION.md Outdated Show resolved Hide resolved
mds1
mds1 previously approved these changes Dec 18, 2024
@sebastianst
Copy link
Member Author

I just realized that this task may have become obsolete by #410 - in this case, I'll change this task to only add the verification framework, but will delete the task sep/026 itself. @mds1 @Inphi @mbaxter

sebastianst added a commit that referenced this pull request Dec 19, 2024
Developed in #421 and now split into its own PR.
Inphi
Inphi previously approved these changes Dec 20, 2024
@sebastianst sebastianst force-pushed the seb/sep-025-fp-fix branch 2 times, most recently from e319959 to 8e8068b Compare January 6, 2025 11:32
@sebastianst sebastianst changed the base branch from main to seb/more-fp-verification January 6, 2025 11:36
auto-merge was automatically disabled January 6, 2025 11:36

Merge commits are not allowed on this repository

@sebastianst sebastianst marked this pull request as draft January 6, 2025 11:40
Copy link
Contributor

@Ethnical Ethnical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! We need to fix the validation file before once this is done we can merge directly!
Sorry for the delay!

Base automatically changed from seb/more-fp-verification to main January 8, 2025 15:33
@sebastianst sebastianst marked this pull request as ready for review January 9, 2025 19:01
@sebastianst sebastianst added this pull request to the merge queue Jan 9, 2025
Merged via the queue into main with commit a49543c Jan 9, 2025
16 checks passed
@sebastianst sebastianst deleted the seb/sep-025-fp-fix branch January 9, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants