Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade MIPS.sol solc version #6384

Merged

Conversation

clabby
Copy link
Member

@clabby clabby commented Jul 20, 2023

Overview

  1. Upgrades MIPS.sol's solc version to 0.8.15, in line with all other bedrock contracts.
  2. Adds a new binding, source_ids.go, that gives the source IDs for all contracts compiled. These are useful for parsing source maps.
  3. Updates the mipsevm source map tracer to support the imported files in MIPS.sol.

@clabby clabby force-pushed the clabby/ctb/upgrade-mips-solc branch from 1292cc1 to 00483cb Compare July 20, 2023 20:46
@changeset-bot
Copy link

changeset-bot bot commented Jul 20, 2023

⚠️ No Changeset found

Latest commit: 07d3134

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the C-protocol-critical Category: Modifies protocol-critical code label Jul 20, 2023
@clabby
Copy link
Member Author

clabby commented Jul 20, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@mergify mergify bot requested a review from tynes July 20, 2023 20:47
@clabby clabby force-pushed the clabby/ctb/local-preimage-key-support branch from f54efeb to bc06d23 Compare July 20, 2023 20:57
@clabby clabby force-pushed the clabby/ctb/upgrade-mips-solc branch 4 times, most recently from 436cc3c to e8f04f3 Compare July 21, 2023 05:27
@semgrep-app
Copy link
Contributor

semgrep-app bot commented Jul 21, 2023

Semgrep found 2 context-todo findings:

  • op-challenger/fault/agent.go: L123, L89

Consider to use well-defined context

Ignore this finding from context-todo.

@clabby clabby force-pushed the clabby/ctb/upgrade-mips-solc branch 3 times, most recently from 1f7456d to 32744c9 Compare July 21, 2023 13:59
@clabby clabby force-pushed the clabby/ctb/local-preimage-key-support branch from d09c723 to fa7b38d Compare July 21, 2023 14:13
@clabby clabby force-pushed the clabby/ctb/upgrade-mips-solc branch 2 times, most recently from cbd238a to 9fd9a79 Compare July 21, 2023 14:18
@clabby clabby force-pushed the clabby/ctb/local-preimage-key-support branch from 19e7860 to 89f311b Compare July 24, 2023 01:50
@clabby clabby force-pushed the clabby/ctb/upgrade-mips-solc branch 5 times, most recently from c3e7cc2 to 8ffd4ae Compare July 25, 2023 14:15
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #6384 (07d3134) into clabby/ctb/local-preimage-key-support (7515872) will increase coverage by 3.71%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                            Coverage Diff                            @@
##           clabby/ctb/local-preimage-key-support    #6384      +/-   ##
=========================================================================
+ Coverage                                  36.91%   40.62%   +3.71%     
=========================================================================
  Files                                        336      360      +24     
  Lines                                      28807    31479    +2672     
  Branches                                    1538     1538              
=========================================================================
+ Hits                                       10633    12789    +2156     
- Misses                                     16942    17254     +312     
- Partials                                    1232     1436     +204     
Flag Coverage Δ
bedrock-go-tests 43.85% <ø> (+3.05%) ⬆️
cannon-go-tests 62.21% <100.00%> (?)
chain-mon-tests 26.95% <ø> (ø)
contracts-bedrock-tests ∅ <ø> (∅)
contracts-ts-tests 6.88% <ø> (ø)
sdk-next-tests 42.60% <ø> (ø)
sdk-tests 42.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cannon/mipsevm/witness.go 82.00% <100.00%> (ø)

... and 43 files with indirect coverage changes

@clabby clabby marked this pull request as ready for review July 25, 2023 15:47
@clabby clabby requested review from a team as code owners July 25, 2023 15:47
@clabby clabby removed the request for review from a team July 25, 2023 15:47
@clabby clabby force-pushed the clabby/ctb/upgrade-mips-solc branch 8 times, most recently from ac2d994 to 892e1a5 Compare July 27, 2023 17:53
@clabby clabby force-pushed the clabby/ctb/local-preimage-key-support branch from f95c9ce to 7515872 Compare July 27, 2023 17:55
@clabby clabby force-pushed the clabby/ctb/upgrade-mips-solc branch 2 times, most recently from 6b0dc86 to 8a2655b Compare July 27, 2023 21:56
@clabby clabby force-pushed the clabby/ctb/upgrade-mips-solc branch from 8a2655b to 07d3134 Compare July 27, 2023 22:00
Copy link
Contributor

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clabby clabby merged commit 6507b8d into clabby/ctb/local-preimage-key-support Jul 28, 2023
6 checks passed
@clabby clabby deleted the clabby/ctb/upgrade-mips-solc branch July 28, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-protocol-critical Category: Modifies protocol-critical code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants