Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update op-geth depdency to 1.14.10 base #12197

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

0x00101010
Copy link
Collaborator

@0x00101010 0x00101010 commented Sep 29, 2024

Description

Updates op-geth to ethereum-optimism/op-geth#392

@0x00101010 0x00101010 force-pushed the francis/geth-v1.14.10 branch 3 times, most recently from 25f35bf to 9a9d8a3 Compare September 29, 2024 23:31
@ajsutton
Copy link
Contributor

Note, the update to go1.22 is currently blocked by it starting to use a new sys call which isn't currently supported by cannon. #12050 fixes that and is pretty close to done I think but we'll need to get it merged before we can switch to go1.22.

The tests in output_cannon_test.go will fail because of the incompatibility but they don't run pre-merge as they're pretty slow.

@0x00101010 0x00101010 force-pushed the francis/geth-v1.14.10 branch 5 times, most recently from b1fa433 to 05b6bd2 Compare September 30, 2024 20:30
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.84%. Comparing base (73038c8) to head (b0148a9).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12197      +/-   ##
===========================================
- Coverage    71.99%   63.84%   -8.15%     
===========================================
  Files           50       56       +6     
  Lines         3910     4409     +499     
===========================================
  Hits          2815     2815              
- Misses         910     1409     +499     
  Partials       185      185              
Flag Coverage Δ
cannon-go-tests 63.84% <100.00%> (-8.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cannon/mipsevm/testutil/evm.go 70.79% <100.00%> (ø)

... and 6 files with indirect coverage changes

@ajsutton
Copy link
Contributor

Cannon now works with go1.22 so we should be good to upgrade op-geth.

@0x00101010
Copy link
Collaborator Author

Cannon now works with go1.22 so we should be good to upgrade op-geth.

Great, thanks! I'll merge in the upstream change.

Currently fixing one e2e test issue

@0x00101010 0x00101010 force-pushed the francis/geth-v1.14.10 branch 6 times, most recently from bf891c9 to 8f3402b Compare October 1, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants