Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding context for circleci #17

Merged
merged 4 commits into from
May 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 3 additions & 42 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,43 +58,6 @@ commands:
# Configure ADC
echo "export GOOGLE_APPLICATION_CREDENTIALS='<< parameters.gcp_cred_config_file_path >>'" | tee -a "$BASH_ENV"

check-changed:
description: "Conditionally halts a step if certain modules change"
parameters:
patterns:
type: string
description: "Comma-separated list of dependencies"
no_go_deps:
type: string
default: ""
description: "If set, does not trigger on `go.mod` / `go.sum` changes."
steps:
- run:
name: "Check for changes"
environment:
CHECK_CHANGED_NO_GO_DEPS: "<<parameters.no_go_deps>>"
command: |
cd ops/check-changed
pip3 install -r requirements.txt
python3 main.py "<<parameters.patterns>>"

notify-failures-on-develop:
description: "Notify Slack"
parameters:
channel:
type: string
default: C03N11M0BBN
mentions:
type: string
default: ""
steps:
- slack/notify:
channel: << parameters.channel >>
event: fail
template: basic_fail_1
branch_pattern: develop
mentions: "<< parameters.mentions >>"

jobs:
docker-build:
environment:
Expand Down Expand Up @@ -209,10 +172,6 @@ jobs:
<<parameters.docker_name>>

no_output_timeout: 45m
- when:
condition: "<<parameters.publish>>"
steps:
- notify-failures-on-develop
- when:
condition: "<<parameters.save_image_tag>>"
steps:
Expand Down Expand Up @@ -261,5 +220,7 @@ workflows:
name: op-monitorism-docker-build
docker_name: op-monitorism
docker_tags: <<pipeline.git.revision>>,<<pipeline.git.branch>>
save_image_tag: <<pipeline.git.revision>> # for devnet later
publish: true
context:
- oplabs-gcr

2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1 +1 @@
* @ethereum-optimism/security-reviewers @hamdiallam
* @ethereum-optimism/security-reviewers