Skip to content

Commit

Permalink
adding context for circleci (#17)
Browse files Browse the repository at this point in the history
* adding context for circleci

* adding publish and remove unused code

* removing save image tag

* updating codeowners
  • Loading branch information
raffaele-oplabs authored May 22, 2024
1 parent a6e6f9e commit 8580844
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 43 deletions.
45 changes: 3 additions & 42 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,43 +58,6 @@ commands:
# Configure ADC
echo "export GOOGLE_APPLICATION_CREDENTIALS='<< parameters.gcp_cred_config_file_path >>'" | tee -a "$BASH_ENV"
check-changed:
description: "Conditionally halts a step if certain modules change"
parameters:
patterns:
type: string
description: "Comma-separated list of dependencies"
no_go_deps:
type: string
default: ""
description: "If set, does not trigger on `go.mod` / `go.sum` changes."
steps:
- run:
name: "Check for changes"
environment:
CHECK_CHANGED_NO_GO_DEPS: "<<parameters.no_go_deps>>"
command: |
cd ops/check-changed
pip3 install -r requirements.txt
python3 main.py "<<parameters.patterns>>"
notify-failures-on-develop:
description: "Notify Slack"
parameters:
channel:
type: string
default: C03N11M0BBN
mentions:
type: string
default: ""
steps:
- slack/notify:
channel: << parameters.channel >>
event: fail
template: basic_fail_1
branch_pattern: develop
mentions: "<< parameters.mentions >>"

jobs:
docker-build:
environment:
Expand Down Expand Up @@ -209,10 +172,6 @@ jobs:
<<parameters.docker_name>>
no_output_timeout: 45m
- when:
condition: "<<parameters.publish>>"
steps:
- notify-failures-on-develop
- when:
condition: "<<parameters.save_image_tag>>"
steps:
Expand Down Expand Up @@ -261,5 +220,7 @@ workflows:
name: op-monitorism-docker-build
docker_name: op-monitorism
docker_tags: <<pipeline.git.revision>>,<<pipeline.git.branch>>
save_image_tag: <<pipeline.git.revision>> # for devnet later
publish: true
context:
- oplabs-gcr

2 changes: 1 addition & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1 +1 @@
* @ethereum-optimism/security-reviewers @hamdiallam
* @ethereum-optimism/security-reviewers

0 comments on commit 8580844

Please sign in to comment.