Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OPENLOOT token #890

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

mferranti
Copy link
Contributor

@mferranti mferranti requested review from wbnns and a team as code owners July 8, 2024 18:17
@wbnns wbnns self-assigned this Jul 12, 2024
@wbnns wbnns added the base label Jul 12, 2024
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mferranti

Hello, CI/CD is failing on this PR with the following issue:

error: OPENLOOT on chain base-sepolia token 0x9acd8e640636b616844c57569028359e46beed43 could not fetch l2Bridge or l1Token.
This token most likely needs nobridge or a bridge override set.

Could you please fix?

@mferranti mferranti force-pushed the add-openloot-token-base branch from 46e8d3b to 77629e6 Compare July 12, 2024 14:25
@mferranti
Copy link
Contributor Author

@mferranti

Hello, CI/CD is failing on this PR with the following issue:

error: OPENLOOT on chain base-sepolia token 0x9acd8e640636b616844c57569028359e46beed43 could not fetch l2Bridge or l1Token.
This token most likely needs nobridge or a bridge override set.

Could you please fix?

Done! i've added the bridge override for base-sepolia

@mferranti mferranti requested a review from wbnns July 12, 2024 14:35
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mferranti

Thanks for the updates. With the recent change the JSON is not formatted correctly in your data.json. Looks like the issue is on Line 17. Can you please fix?

@mferranti mferranti force-pushed the add-openloot-token-base branch from 77629e6 to 4e57259 Compare July 22, 2024 14:16
@mferranti mferranti requested a review from wbnns July 22, 2024 14:16
@mferranti
Copy link
Contributor Author

@wbnns it should be ok now! thanks!

Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@mferranti Thanks for the updates and for building on Base 🔵

@mergify mergify bot merged commit d3f0e9e into ethereum-optimism:master Jul 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants