Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CHI token #862

Closed
wants to merge 4 commits into from
Closed

Conversation

dusan-mrsic
Copy link
Contributor

Token name and symbol is CHI. It is added in CHI-PROTOCOL folder because there is already CHI folder in project.

@dusan-mrsic dusan-mrsic requested a review from a team as a code owner June 14, 2024 07:59
@wbnns wbnns added the base label Jun 15, 2024
@wbnns wbnns self-assigned this Jun 15, 2024
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dusan-mrsic

Hi there! CI is failing with the following issue:

error: CHI-PROTOCOL on chain base token 0x3b21418081528845a6DF4e970bD2185545b712ba could not fetch l2Bridge or l1Token.

This token most likely needs nobridge or a bridge override set.

Could you please fix and update the PR?

@dusan-mrsic
Copy link
Contributor Author

Hi @wbnns , can the problem be with the name? Because symbol is CHI, but folder name is CHI-PROTOCOL, but I didn't know what to put because there is already CHI folder?

@wbnns
Copy link
Member

wbnns commented Jun 20, 2024

@dusan-mrsic

Heya, hm, yeah -- let's loop in @annieke or @hamdiallam here. 🤔

@hamdiallam
Copy link
Contributor

Hey @dusan-mrsic, this error isn't due to the name but due to the contract itself.

How is this token bridged from L1, through the standard bridge contracts? If so it's not a proper OptimismMintableERC20. I would recommend not extending the interface but the concrete contract. Then supply the appropriate constructor arguments

@wbnns
Copy link
Member

wbnns commented Jun 25, 2024

@dusan-mrsic

Will close this PR for now. Please let us know if you'd like to pursue this change and we can reopen. 👍

@wbnns wbnns closed this Jun 25, 2024
@dusan-mrsic
Copy link
Contributor Author

@wbnns @hamdiallam But why this is the problem? It is extending IOptimismMintableERC20. Our token USC is the same as this one and it is merged without problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants