Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CHAR on Base #812

Merged
merged 3 commits into from
May 3, 2024
Merged

add CHAR on Base #812

merged 3 commits into from
May 3, 2024

Conversation

lirona
Copy link
Contributor

@lirona lirona commented Apr 30, 2024

adding Toucan's CHAR token on Base

@cfluke-cb @wbnns for your review, thanks!

@lirona lirona requested a review from a team as a code owner April 30, 2024 15:24
wbnns
wbnns previously requested changes May 1, 2024
View reviewed changes
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lirona

Hi there! Can you please add the "nonstandard": true, option to your json?

@wbnns wbnns added the base label May 1, 2024
@mergify mergify bot dismissed wbnns’s stale review May 1, 2024 06:56

Pull request has been modified.

wbnns
wbnns approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@lirona Thanks for building on Base 🔵

@wbnns wbnns self-assigned this May 3, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 3, 2024

Merge failed. Please see automated check logs for more details.

@annieke annieke merged commit de05662 into ethereum-optimism:master May 3, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annieke annieke annieke approved these changes

@wbnns wbnns wbnns approved these changes

Assignees

@wbnns wbnns

Labels
base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lirona @wbnns @annieke