Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base L2 token address for MKR #807

Merged
merged 3 commits into from
May 3, 2024

Conversation

fmorisan
Copy link
Contributor

Description

Adds Maker (MKR) L2 token address for Base. The contract was deployed using the OptimismMintableERC20Factory contract at transaction 0x10c63281910a992ddb5fa5bf29bfb0369af92a35328699864da45081fdfc61f6.

The token's remote address has been set to 0x9f8f72aa9304c8b593d555f12ef6589cc3a579a2, which is MKR's address on ETH Mainnet.

@fmorisan fmorisan requested a review from a team as a code owner April 27, 2024 23:56
@fmorisan
Copy link
Contributor Author

Tagging @cfluke-cb and @wbnns as per this link

@rcbgr
Copy link

rcbgr commented Apr 29, 2024

hey @fmorisan, your JSON is invalid

@rcbgr rcbgr added the base label Apr 29, 2024
@fmorisan
Copy link
Contributor Author

fmorisan commented Apr 29, 2024

looks valid to me... what's wrong with it? jq at least doesn't complain
image

Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fmorisan

Thanks for the PR! Could you please confirm your affiliation with MKR?

@fmorisan
Copy link
Contributor Author

I confirm my affiliation to MakerDAO.

@wbnns
Copy link
Member

wbnns commented May 1, 2024

@fmorisan

Thanks for confirming. We also just wanted to confirm as a second factor through our channels. Will follow-up here as soon as I have an update!

Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, ACK

@fmorisan Thanks for building on Base 🔵

@fmorisan
Copy link
Contributor Author

fmorisan commented May 2, 2024

Thanks!

@wbnns wbnns self-assigned this May 3, 2024
@mergify mergify bot merged commit d831299 into ethereum-optimism:master May 3, 2024
4 checks passed
wbnns added a commit that referenced this pull request Jun 11, 2024
mergify bot pushed a commit that referenced this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants