Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MCADE to Base #780

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Add MCADE to Base #780

merged 3 commits into from
Apr 30, 2024

Conversation

Quix44
Copy link
Contributor

@Quix44 Quix44 commented Apr 10, 2024

Description

Adding testnet token to bridge from Eth -> Base to fully understand the workflow before doing mainnet. Token was created with from the instructions outlined https://docs.base.org/docs/tokens/list/ (OptimismMintableERC20Factory)

@Quix44 Quix44 requested a review from a team as a code owner April 10, 2024 13:55
@Quix44
Copy link
Contributor Author

Quix44 commented Apr 10, 2024

Adding @cfluke-cb as reviewer

@Quix44 Quix44 changed the title Add MCADE (testnet) to Base Add MCADE to Base Apr 15, 2024
@Quix44
Copy link
Contributor Author

Quix44 commented Apr 24, 2024

cc: as reviewers
@wbnns
@taycaldwell

cfluke-cb
cfluke-cb approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@cfluke-cb cfluke-cb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you verify the contracts on testnets and have the token names match?

error: MCADE on chain sepolia token 0x9975451FB0B41AfE849390a6A20b502F17B35ec7 has incorrect name. Got MCADE
error: MCADE on chain base-sepolia token 0x41E6C9902a27D1995585C1B2DbA06569BBFb90Bc has incorrect name. Got MCADE
error: final token list is invalid
warning: MCADE on chain sepolia token 0x9975451FB0B41AfE849390a6A20b502F17B35ec7 code not verified on Etherscan

@cfluke-cb cfluke-cb self-requested a review April 25, 2024 17:02
cfluke-cb
cfluke-cb previously requested changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@cfluke-cb cfluke-cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you verify the contracts on testnets and have the token names match?

error: MCADE on chain sepolia token 0x9975451FB0B41AfE849390a6A20b502F17B35ec7 has incorrect name. Got MCADE
error: MCADE on chain base-sepolia token 0x41E6C9902a27D1995585C1B2DbA06569BBFb90Bc has incorrect name. Got MCADE
error: final token list is invalid

@mergify mergify bot dismissed cfluke-cb’s stale review April 25, 2024 17:29

Pull request has been modified.

@Quix44
Copy link
Contributor Author

Quix44 commented Apr 25, 2024

Thanks @cfluke-cb - i've updated the token name to match - please check again when time permits

wbnns
wbnns approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@Quix44 Quix44 requested review from cfluke-cb and wbnns April 28, 2024 19:29
@hamdiallam hamdiallam merged commit 6c7974a into ethereum-optimism:master Apr 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamdiallam hamdiallam hamdiallam approved these changes

@cfluke-cb cfluke-cb Awaiting requested review from cfluke-cb

@wbnns wbnns Awaiting requested review from wbnns wbnns is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Quix44 @wbnns @hamdiallam @cfluke-cb