Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added IMGNAI #775

Merged
merged 5 commits into from
May 13, 2024
Merged

Added IMGNAI #775

merged 5 commits into from
May 13, 2024

Conversation

RustlerK
Copy link
Contributor

@RustlerK RustlerK commented Apr 8, 2024

  • NB: Token contract contains the ability to apply per-pool fee on v2 pool transactions, and has the bridge contract excluded/restricted from being added as a taxable address.

All transfers to/from any excluded addresses (pre-filled with 0x4200000000000000000000000000000000000010) cannot be charged any fee on tx.

base contract deployment will be held by the imgnai.eth multisig, ensuring against any erroneous fee pair additions.

Description

Added imgnAI Base contract & details

Tests

Test contract deployed on BASE, ensured no interference with fee on uniswap v2 pool txs against any bridge addr. Carried out additional mint/burn testing from deployer wallet, with deployer set as BRIDGE.

- NB: Token contract contains the ability to apply per-pool fee on v2 pool transactions, and has the bridge contract excluded/restricted from being added as a taxable address.

All transfers to/from any excluded addresses (pre-filled with 0x4200000000000000000000000000000000000010) cannot be charged any fee on tx.

base contract deployment will be held by the imgnai.eth multisig, ensuring against any erroneous fee pair additions.
@RustlerK RustlerK requested a review from a team as a code owner April 8, 2024 22:05
@annieke annieke added the base label Apr 10, 2024
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RustlerK

Hi there! The CI / verification of the data submitted is failing on this PR. Could you please fix?

@RustlerK
Copy link
Contributor Author

Hi @wbnns - redeployed base contract to align with imgnai's original name/symbol, and updated in the data json.

Looks like all automated tests are now passing as expected - could you re-review when ready?

wbnns
wbnns previously requested changes Apr 30, 2024
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RustlerK

Thanks! Can you please add the "nonstandard": true, option to your data.json as well?

@mergify mergify bot dismissed wbnns’s stale review May 5, 2024 18:08

Pull request has been modified.

@RustlerK
Copy link
Contributor Author

RustlerK commented May 5, 2024

Hey @wbnns - apologies for the delay, updated as requested. Please let me know if anything else is needed here :)

Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@RustlerK Thanks for building on Base and also for the updates 🔵

wbnns
wbnns previously requested changes May 8, 2024
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RustlerK

Heya, we noticed that the validation is still failing; it looks like it's because the name and symbol don't perfectly match L1. Can you please update or use overrides?

Details here:
https://github.com/ethereum-optimism/ethereum-optimism.github.io?tab=readme-ov-file#automated-checks

@RustlerK
Copy link
Contributor Author

RustlerK commented May 8, 2024

Hey @wbnns - problem in validation seems to be stemming from the actual token name;

These errors caused the validation to fail:
final token list is invalid: [
  {
    "instancePath": "/tokens/191/name",
    "schemaPath": "#/properties/name/pattern",
    "keyword": "pattern",
    "params": {
      "pattern": "^[ \\w.'+\\-%/À-ÖØ-öø-ÿ:&\\[\\]\\(\\)]+$"
    },
    "message": "must match pattern \"^[ \\w.'+\\-%/À-ÖØ-öø-ÿ:&\\[\\]\\(\\)]+$\"",
    "schema": "^[ \\w.'+\\-%/À-ÖØ-öø-ÿ:&\\[\\]\\(\\)]+$",
    "parentSchema": {
      "type": "string",
      "description": "The name of the token",
      "minLength": 1,
      "maxLength": 40,
      "pattern": "^[ \\w.'+\\-%/À-ÖØ-öø-ÿ:&\\[\\]\\(\\)]+$",
      "examples": [
        "USD Coin"
      ]
    },
    "data": "Image Generation AI | imgnAI.com"
  }
]

This is our actual/valid token name on Ethereum; https://etherscan.io/token/0xa735a3af76cc30791c61c10d585833829d36cbe0

However, we have since rebranded to Imagine AI; I've re-deployed our token contract on Base to reflect this, and updated it in the data.json.

For the Ethereum override, I've used "Image Generation AI" (cutting the | url suffix) - looks like all tests are passing now :)

@mergify mergify bot dismissed wbnns’s stale review May 8, 2024 01:50

Pull request has been modified.

Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@RustlerK Thanks for fixing 🤝

@hamdiallam hamdiallam merged commit 3642130 into ethereum-optimism:master May 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants