Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$GCH ON BASE #743

Closed
wants to merge 4 commits into from
Closed

$GCH ON BASE #743

wants to merge 4 commits into from

Conversation

Legendarylibr
Copy link

@Legendarylibr Legendarylibr commented Mar 31, 2024 •
edited
Loading

Description
@cfluke-cb
$GCH is a memecoin on ETH that wishes to have an alternative for lower transaction fees

Tests
No tests, pretty straight forward with a fork.

Additional context

Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

@Legendarylibr Legendarylibr requested a review from a team as a code owner March 31, 2024 20:35
@Legendarylibr
Copy link
Author

@cfluke-cb

@Legendarylibr Legendarylibr changed the title Based $GCH $GCH ON BASE @cfluke-cb Apr 2, 2024
@Legendarylibr Legendarylibr changed the title $GCH ON BASE @cfluke-cb $GCH ON BASE Apr 2, 2024
@annieke annieke requested a review from cfluke-cb April 2, 2024 19:07
@Legendarylibr
Copy link
Author

alternative image: https://svgshare.com/i/14yo.svg

@cfluke-cb
Copy link
Contributor

Hi @BlockedDao can you update to your alternative image?
Can you modify the website property to be a full uri, e.g.? "website": "https://goochtoken.xyz",

Can you also add the token to coingecko?
warning: GCH on chain ethereum token 0x42379293f2b7a5b379abf54329a8CfdD0E518a9B not found on CoinGecko token list

@Legendarylibr
Update data.json
075dd19 
Update to full website url
@Legendarylibr
Update logo.svg
c9b7287 
Updated logo url
@Legendarylibr
Copy link
Author

Legendarylibr commented Apr 24, 2024 •
edited
Loading

Hi @BlockedDao can you update to your alternative image? Can you modify the website property to be a full uri, e.g.? "website": "https://goochtoken.xyz",

Can you also add the token to coingecko? warning: GCH on chain ethereum token 0x42379293f2b7a5b379abf54329a8CfdD0E518a9B not found on CoinGecko token list

All those should be completed now @cfluke-cb

wbnns
wbnns requested changes Apr 26, 2024
View reviewed changes
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BlockedDao

Hi there! Can you please update the SVG? It's not rendering.
2024-04-26 at 22 29 41@2x

@wbnns wbnns self-assigned this May 3, 2024
@wbnns
Copy link
Member

wbnns commented May 8, 2024

@BlockedDao

Since it's been a while and we haven't heard back, closing this for now. Please let us know if you'd like to pursue the additional changes to resolve the outstanding issues on the PR and we can reopen. 👍

@wbnns wbnns closed this May 8, 2024
@Legendarylibr
Copy link
Author

@BlockedDao

Since it's been a while and we haven't heard back, closing this for now. Please let us know if you'd like to pursue the additional changes to resolve the outstanding issues on the PR and we can reopen. 👍

yes i would like to resolve these issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbnns wbnns wbnns requested changes

@cfluke-cb cfluke-cb Awaiting requested review from cfluke-cb

Assignees

@wbnns wbnns

Labels
base waiting-for-pr-author-response
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Legendarylibr @cfluke-cb @wbnns @annieke