Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zunUSD and zunETH to Optimism and Base #693

Merged
merged 3 commits into from
May 6, 2024

Conversation

@MioGreen MioGreen requested a review from a team as a code owner March 14, 2024 17:21
@hamdiallam
Copy link
Contributor

Hi! The validation script needs to pass


2024-03-20T17:43:19.6774347Z error: zunUSD on chain ethereum token 0x2b95a1dcc3d405535f9ed33c219ab38e8d7e0884 has incorrect name

@MioGreen
Copy link
Contributor Author

@hamdiallam thank you for the notification. fixed.

@MioGreen MioGreen changed the title Add zunUSD to Optimism and Base Add zunUSD and zunETH to Optimism and Base Apr 19, 2024
wbnns
wbnns previously requested changes Apr 26, 2024
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MioGreen

Heya, it looks like there is a difference in the resolution/size of the zunUSD and zunETH SVGs; can you please double-check and resolve?

@MioGreen
Copy link
Contributor Author

@wbnns

Do you have any recommendations about SVG logos?

@wbnns
Copy link
Member

wbnns commented Apr 30, 2024

@MioGreen Hello, it appears they're rendering differently when you look at the diff for the PR (one very small, the other significantly larger).

@mergify mergify bot dismissed wbnns’s stale review May 1, 2024 03:40

Pull request has been modified.

Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@MioGreen Thanks for building on Base 🔵

@wbnns wbnns self-assigned this May 3, 2024
@wbnns wbnns added the op label May 3, 2024
@hamdiallam hamdiallam merged commit f9b5b77 into ethereum-optimism:master May 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants