Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wstETH BASE #566

Merged
merged 5 commits into from
Nov 13, 2023
Merged

Conversation

MirthFutures
Copy link
Contributor

Description

A clear and concise description of the features you're adding in this pull request.

Tests

Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.

Additional context

Add any other context about the problem you're solving.

Metadata

  • Fixes #[Link to Issue]

@MirthFutures MirthFutures requested review from a team as code owners November 2, 2023 15:18
@MirthFutures MirthFutures requested a review from jakim929 November 2, 2023 15:18
@TheDZhon
Copy link

TheDZhon commented Nov 2, 2023

I guess there should be an override for Base

{
  "name": "Wrapped liquid staked Ether 2.0",
  "symbol": "wstETH",
  "decimals": 18,
  "tokens": {
    "ethereum": {
      "address": "0x7f39C581F595B53c5cb19bD0b3f8dA6c935E2Ca0",
      "overrides": {
        "bridge": {
          "optimism": "0x76943C0D61395d8F2edF9060e1533529cAe05dE6",
          +"base": "0x9de443AdC5A411E83F1878Ef24C3F52C61571e72"
        }
      }
    },
    "optimism": {
      "address": "0x1F32b1c2345538c0c6f582fCB022739c4A194Ebb",
      "overrides": {
        "bridge": "0x8E01013243a96601a86eb3153F0d9Fa4fbFb6957"
      }
    },
    "base": {
      "address": "0xc1CBa3fCea344f92D9239c08C0568f6F2F0ee452",
      "overrides": {
        "bridge": "0xac9D11cD4D7eF6e54F14643a393F68Ca014287AB"
      }
    },
  }
}

@MirthFutures
Copy link
Contributor Author

Added, sorry about that miss

@TheDZhon
Copy link

TheDZhon commented Nov 3, 2023

@GabrielaMelendezQuan
Copy link

Hi @MirthFutures,
Can you please provide the following information for each of these two addresses? 0xac9D11cD4D7eF6e54F14643a393F68Ca014287AB and 0x0E37599436974a25dDeEdF795C848d30Af46eaCF

  1. The nature of any multi-sig or other custody setup (# signers required / total signers, or other guarded access)
  2. A claim indicating how many are independent signers (i.e. different individuals) - ideally please indicate the addresses of the multisig participants and the associated holder identities for those addresses
  3. Whether you use a hardware wallet, and if not where the keys are stored
  4. Any 3rd party audit from a reputable auditor that the requirements have been met, and/or provide access to Coinbase so that Coinbase can validate the controls (by providing us with the multi-sig address to verify on chain)
  5. A commitment to providing notification of any changes to this validated, audited process

@kadmil
Copy link

kadmil commented Nov 8, 2023

gm gm @GabrielaMelendezQuan!

The bridging contract's 0xac9D11cD4D7eF6e54F14643a393F68Ca014287AB upgradability is managed by a dedicated smart contract called OptimismBridgeExecutor at 0x0E37599436974a25dDeEdF795C848d30Af46eaCF.

This setup allows the upgrade authority to lay squarely on Lido DAO Aragon Agent contract 0x3e40D73EB977Dc6a537aF587D48316feE66E9C8c (check out the address at Lido docs), setting the upgradability through the cross-chain governance motion passing. That means no multisigs are connected to the regular operation of the bridging parts on Base or on mainnet.

That said, one more thing to note is that there's a dedicated Emergency Brakes multisig with the roles to pause deposits or withdrawals on either mainnet or Base side of the bridging parts (DEPOSITS_DISABLER_ROLE & WITHDRAWALS_DISABLER_ROLE). Said multisig has public and Lido DAO-vetted setup (latest update vote with all relevant details can be found here: https://snapshot.org/#/lido-snapshot.eth/proposal/0xfe2a6a6506a642b616118363bc29aa83dd9ef2ec80447bb607a8f52c0a96aed0; follow the links to discussion for deeper context).

As for the audits, the code used has been audited under the project of enabling WstETH bridging to Optimism (the audit can be found here: https://github.com/lidofinance/audits#08-2022-oxorio-governance-crosschain-bridges-smart-contracts-security-audit-report) & verified that the Base deployment uses the same code: https://research.lido.fi/t/wsteth-deployment-to-base-and-ownership-acceptance-by-lido-dao/5668/5

roberto-bayardo
roberto-bayardo previously approved these changes Nov 8, 2023
Copy link
Collaborator

@roberto-bayardo roberto-bayardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from Base side.

@hamdiallam
Copy link
Contributor

@MirthFutures

Thanks for the elaborate response, all looks good on our end as well! Can you rebase in order for the test script to pass? The Major version has been bumped

hamdiallam
hamdiallam previously approved these changes Nov 13, 2023
@mergify mergify bot dismissed stale reviews from hamdiallam and roberto-bayardo November 13, 2023 15:48

Pull request has been modified.

Copy link
Contributor

mergify bot commented Nov 13, 2023

Merge failed. Please see automated check logs for more details.

@hamdiallam hamdiallam merged commit 5c14272 into ethereum-optimism:master Nov 13, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants