-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wstETH BASE #566
Add wstETH BASE #566
Conversation
I guess there should be an override for Base {
"name": "Wrapped liquid staked Ether 2.0",
"symbol": "wstETH",
"decimals": 18,
"tokens": {
"ethereum": {
"address": "0x7f39C581F595B53c5cb19bD0b3f8dA6c935E2Ca0",
"overrides": {
"bridge": {
"optimism": "0x76943C0D61395d8F2edF9060e1533529cAe05dE6",
+"base": "0x9de443AdC5A411E83F1878Ef24C3F52C61571e72"
}
}
},
"optimism": {
"address": "0x1F32b1c2345538c0c6f582fCB022739c4A194Ebb",
"overrides": {
"bridge": "0x8E01013243a96601a86eb3153F0d9Fa4fbFb6957"
}
},
"base": {
"address": "0xc1CBa3fCea344f92D9239c08C0568f6F2F0ee452",
"overrides": {
"bridge": "0xac9D11cD4D7eF6e54F14643a393F68Ca014287AB"
}
},
}
} |
Added, sorry about that miss |
Co-authored-by: Roberto Bayardo <[email protected]>
Hi @MirthFutures,
|
gm gm @GabrielaMelendezQuan! The bridging contract's 0xac9D11cD4D7eF6e54F14643a393F68Ca014287AB upgradability is managed by a dedicated smart contract called OptimismBridgeExecutor at 0x0E37599436974a25dDeEdF795C848d30Af46eaCF. This setup allows the upgrade authority to lay squarely on Lido DAO Aragon Agent contract 0x3e40D73EB977Dc6a537aF587D48316feE66E9C8c (check out the address at Lido docs), setting the upgradability through the cross-chain governance motion passing. That means no multisigs are connected to the regular operation of the bridging parts on Base or on mainnet. That said, one more thing to note is that there's a dedicated Emergency Brakes multisig with the roles to pause deposits or withdrawals on either mainnet or Base side of the bridging parts ( As for the audits, the code used has been audited under the project of enabling WstETH bridging to Optimism (the audit can be found here: https://github.com/lidofinance/audits#08-2022-oxorio-governance-crosschain-bridges-smart-contracts-security-audit-report) & verified that the Base deployment uses the same code: https://research.lido.fi/t/wsteth-deployment-to-base-and-ownership-acceptance-by-lido-dao/5668/5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good from Base side.
Thanks for the elaborate response, all looks good on our end as well! Can you rebase in order for the test script to pass? The Major version has been bumped |
Pull request has been modified.
Merge failed. Please see automated check logs for more details. |
Description
A clear and concise description of the features you're adding in this pull request.
Tests
Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.
Additional context
Add any other context about the problem you're solving.
Metadata