Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base address of ARIA20 #556

Merged
merged 10 commits into from
Nov 13, 2023
Merged

Conversation

gnarco
Copy link
Contributor

@gnarco gnarco commented Oct 25, 2023

Add ARIA20 token to Base standard bridge.

Aria20 is the native token for Arianee Protocol : https://arianee.org

https://www.coingecko.com/en/coins/arianee

@roberto-bayardo

@gnarco gnarco requested review from a team as code owners October 25, 2023 15:02
@gnarco gnarco requested a review from nitaliano October 25, 2023 15:02
@hamdiallam
Copy link
Contributor

Hi @gnarco, the title states a base address is being added but don't see one listed in the files changed

any chance you haven't pushed ur latest changes?

@gnarco
Copy link
Contributor Author

gnarco commented Oct 25, 2023

@hamdiallam It was my mistake. Fixed.

@spacesailor24
Copy link
Contributor

@gnarco The validation script is failing with

error: ARIA20 on chain ethereum token 0xeDF6568618A00C6F0908Bf7758A16F76B6E04aF9 has incorrect name

The name you have in the config is ARIA20, but the name for the ETH contract is ARIANEE, and for Base it's Arianee. Please update the names to match and run the verification script locally to make sure it passes

@gnarco
Copy link
Contributor Author

gnarco commented Oct 27, 2023

Before making any changes, I want to be sure :

On Ethereum mainnet :
Name = ARIANEE
Symbol = ARIA20

On Base :
Name = Arianee
Symbol = ARIA20

In config
Name = Arianee
Symbol = ARIA20

The issue is the case in the name in Base and in config ?
If yes, do you confirm, that I need to redeploy a token on base with the right case, and update the config accordingly ?
@spacesailor24

or perhaps it's the name of the directory in my PR (ARIA20 should be ARIANEE ?)

Thanks !

@gnarco
Copy link
Contributor Author

gnarco commented Oct 27, 2023

After checking the validation process, it seems it was a case issue.
I just deploy a new token with the right case

@hamdiallam
Copy link
Contributor

hamdiallam commented Oct 27, 2023

After checking the validation process, it seems it was a case issue. I just deploy a new token with the right case

Yea try to enforce matching token property fields unless it's absolutely necessary to break, thanks for updating!

cc @roberto-bayardo for a sign off on the base side

@gnarco
Copy link
Contributor Author

gnarco commented Oct 27, 2023

I forgot to update data.json.
Sorry

Copy link

github-actions bot commented Nov 4, 2023

This pr has been automatically marked as stale and will be closed in 7 days if no updates

@github-actions github-actions bot added the Stale label Nov 4, 2023
@gnarco
Copy link
Contributor Author

gnarco commented Nov 6, 2023

Hi @roberto-bayardo

Any news ?

@roberto-bayardo
Copy link
Collaborator

apologies taking a look

@roberto-bayardo roberto-bayardo added base and removed Stale labels Nov 6, 2023
Copy link
Collaborator

@roberto-bayardo roberto-bayardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for base

@gnarco
Copy link
Contributor Author

gnarco commented Nov 13, 2023

@hamdiallam @nitaliano
How can we finish the process ?

Thanks !

Copy link
Contributor

@hamdiallam hamdiallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep! Sorry for the delay

Copy link
Contributor

mergify bot commented Nov 13, 2023

Merge failed. Please see automated check logs for more details.

@hamdiallam hamdiallam merged commit 09e4c3f into ethereum-optimism:master Nov 13, 2023
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants