-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected Hyphenation Issues in Documentation #1147
Conversation
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe pull request introduces several minor textual modifications across various documentation files to enhance grammatical accuracy and clarity. Changes include correcting hyphenation issues, such as updating "brand new" to "brand-new" and "future proof" to "future-proof." Additionally, phrases like "an git issue" were corrected to "a git issue," and "twelve second period" was changed to "twelve-second period." The updates also clarify requirements for code imports in the Nextra framework documentation, emphasizing the necessity of including an MD5 content hash. Furthermore, the "Fault proofs explainer" document received substantial updates to improve clarity regarding the OP Stack's Fault Proof System, including details about its activation, functionalities, and security measures. Overall, the changes focus on enhancing the readability and accuracy of the documentation without altering the underlying content or functionality. Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (5)
pages/stack/fault-proofs/explainer.mdx (1)
Line range hint
1-1
: Update header capitalization for consistencyAccording to the documentation guidelines, headers should use sentence case while preserving the capitalization of technical terms. Please update the following headers:
- title: Fault proofs explainer + title: Fault Proofs explainer - # Fault proofs explainer + # Fault Proofs explainer - ## Permissionless proposals + ## Permissionless Proposals - ## Permissionless challenges + ## Permissionless Challenges - ## FAQs + ## Frequently asked questionsAlso applies to: 8-8, 31-31, 43-43, 89-89
pages/stack/interop/explainer.mdx (4)
Line range hint
1-5
: Convert title to sentence caseAccording to the coding guidelines, H1, H2, and H3 headers should use sentence case. Change:
-title: Interoperability explainer +title: Interoperability Explainer
36-38
: Remove personal pronouns from documentationReplace personal pronouns with proper nouns to maintain consistency in communal documentation. Change:
-This gives the OP Stack an unopinionated and flexible foundation, so chain operators can choose which chains their chains depend on +This gives the OP Stack an unopinionated and flexible foundation, allowing chain operators to choose which chains the deployed chains depend on
Line range hint
89-93
: Apply consistent capitalization to technical termsTechnical terms should maintain consistent capitalization. In the BeaconContract section, ensure consistent capitalization:
-BeaconProxies +BeaconProxy contracts
Line range hint
103-107
: Use Oxford comma consistentlyAdd Oxford comma in the list for consistency:
-Chain operators will need to run additional infrastructure to be part of the interoperable set. +Chain operators will need to run additional infrastructure to be part of the interoperable set:
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (10)
.github/ISSUE_TEMPLATE/general_docs_request.md
(1 hunks)notes/nextra.md
(1 hunks)pages/500.mdx
(1 hunks)pages/builders/app-developers/bridging/messaging.mdx
(1 hunks)pages/builders/app-developers/transactions/estimates.mdx
(1 hunks)pages/builders/app-developers/transactions/troubleshooting.mdx
(1 hunks)pages/stack/components.mdx
(1 hunks)pages/stack/fault-proofs/explainer.mdx
(1 hunks)pages/stack/interop/explainer.mdx
(1 hunks)pages/stack/security/faq.mdx
(1 hunks)
✅ Files skipped from review due to trivial changes (6)
- pages/500.mdx
- pages/builders/app-developers/bridging/messaging.mdx
- pages/builders/app-developers/transactions/estimates.mdx
- pages/builders/app-developers/transactions/troubleshooting.mdx
- pages/stack/components.mdx
- pages/stack/security/faq.mdx
🧰 Additional context used
📓 Path-based instructions (2)
pages/stack/fault-proofs/explainer.mdx (1)
Pattern **/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
pages/stack/interop/explainer.mdx (1)
Pattern **/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
🪛 LanguageTool
.github/ISSUE_TEMPLATE/general_docs_request.md
[uncategorized] ~12-~12: Possible missing comma found.
Context: ..., is the request related to an existing page or are you suggesting a brand-new docs ...
(AI_HYDRA_LEO_MISSING_COMMA)
🔇 Additional comments (4)
notes/nextra.md (2)
17-17
: LGTM! Clear explanation of the MD5 hash requirement
The documentation clearly explains the technical requirement and its rationale, helping developers understand why MD5 content hashes are necessary for code imports.
17-17
: Verify the referenced patch file
Let's ensure the referenced patch file exists and is accessible.
✅ Verification successful
Patch file exists and implements MD5 hash requirement correctly
The patch file exists and implements the stated functionality by:
- Adding MD5 hash validation for imported code content
- Requiring a
hash=
parameter with every code import - Verifying the provided hash matches the actual content hash
- Providing helpful error messages that include the expected hash when validation fails
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the existence of the referenced patch file
# Check if the patch file exists
if [ -f "patches/[email protected]" ]; then
echo "✓ Patch file exists"
# Show first few lines of the patch to verify it's related to MD5 hash requirement
head -n 5 "patches/[email protected]"
else
echo "✗ Patch file not found at patches/[email protected]"
fi
Length of output: 346
Script:
#!/bin/bash
# Let's examine the full patch content to verify the MD5 hash requirement
cat patches/[email protected]
Length of output: 3119
pages/stack/fault-proofs/explainer.mdx (1)
95-95
: LGTM: Correct hyphenation of "counter-claim"
The hyphenation is properly applied to the compound term.
pages/stack/interop/explainer.mdx (1)
36-36
: Correct hyphenation of compound adjective
The hyphenation of "per-chain" is grammatically correct as it's used as a compound adjective modifying "basis".
This pull request addresses multiple instances of missing hyphens and inconsistent formatting throughout the documentation. Specifically, the changes include:
These changes ensure proper grammar and improve the clarity of the documentation.
Tests:
No tests have been added as this PR only includes documentation improvements.
Additional Context:
This PR enhances readability and correctness in technical documentation.