Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected Hyphenation Issues in Documentation #1147

Merged
merged 10 commits into from
Nov 27, 2024

Conversation

Dimitrolito
Copy link
Contributor

This pull request addresses multiple instances of missing hyphens and inconsistent formatting throughout the documentation. Specifically, the changes include:

  • Adding hyphens to terms such as "future-proof", "denial-of-service", and "decision-making".
  • Correcting hyphenation in "per-chain" and "counter-claim".
  • Ensuring consistent usage of compound adjectives in the context of technical terms.

These changes ensure proper grammar and improve the clarity of the documentation.

Tests:
No tests have been added as this PR only includes documentation improvements.

Additional Context:
This PR enhances readability and correctness in technical documentation.

@Dimitrolito Dimitrolito requested a review from a team as a code owner November 27, 2024 14:32
Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit 02ea8e7
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/67472d79e2608600088253bf
😎 Deploy Preview https://deploy-preview-1147--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Nov 27, 2024

📝 Walkthrough

Walkthrough

The pull request introduces several minor textual modifications across various documentation files to enhance grammatical accuracy and clarity. Changes include correcting hyphenation issues, such as updating "brand new" to "brand-new" and "future proof" to "future-proof." Additionally, phrases like "an git issue" were corrected to "a git issue," and "twelve second period" was changed to "twelve-second period." The updates also clarify requirements for code imports in the Nextra framework documentation, emphasizing the necessity of including an MD5 content hash. Furthermore, the "Fault proofs explainer" document received substantial updates to improve clarity regarding the OP Stack's Fault Proof System, including details about its activation, functionalities, and security measures. Overall, the changes focus on enhancing the readability and accuracy of the documentation without altering the underlying content or functionality.

Possibly related PRs

  • docs: enhancements and typos #708: This PR includes typo fixes and enhancements in documentation, which may relate to the grammatical corrections made in the main PR.
  • Fix docs #797: This PR addresses documentation fixes, including grammatical corrections, which aligns with the minor grammatical changes in the main PR.
  • Docs improvements #776: Similar to the main PR, this PR focuses on fixing typographical errors in documentation, indicating a shared objective of improving documentation clarity.
  • Corrected rude grammar errors in docs #1055: This PR corrects grammar errors in documentation, which is directly related to the grammatical corrections made in the main PR.
  • Update docs files with errors #1100: This PR addresses grammatical errors in various documentation files, which aligns with the focus of the main PR on correcting grammar.
  • Update cross-chain-message.mdx #1103: This PR updates the interoperability explainer to enhance clarity, which may relate to the overall objective of improving documentation quality seen in the main PR.
  • Documentation Text Fixes Changes Made #1128: This PR focuses on fixing grammatical errors in multiple documentation files, which is consistent with the changes made in the main PR.
  • Fix typos and remove duplicate entries Changes Made #1136: This PR corrects typographical errors in documentation templates, which aligns with the grammatical corrections in the main PR.
  • Typo README.md #1137: This PR corrects a redundancy in the README title, which reflects the focus on improving documentation quality seen in the main PR.

Suggested labels

documentation

Suggested reviewers

  • sbvegan

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (5)
pages/stack/fault-proofs/explainer.mdx (1)

Line range hint 1-1: Update header capitalization for consistency

According to the documentation guidelines, headers should use sentence case while preserving the capitalization of technical terms. Please update the following headers:

- title: Fault proofs explainer
+ title: Fault Proofs explainer

- # Fault proofs explainer
+ # Fault Proofs explainer

- ## Permissionless proposals
+ ## Permissionless Proposals

- ## Permissionless challenges
+ ## Permissionless Challenges

- ## FAQs
+ ## Frequently asked questions

Also applies to: 8-8, 31-31, 43-43, 89-89

pages/stack/interop/explainer.mdx (4)

Line range hint 1-5: Convert title to sentence case

According to the coding guidelines, H1, H2, and H3 headers should use sentence case. Change:

-title: Interoperability explainer
+title: Interoperability Explainer

36-38: Remove personal pronouns from documentation

Replace personal pronouns with proper nouns to maintain consistency in communal documentation. Change:

-This gives the OP Stack an unopinionated and flexible foundation, so chain operators can choose which chains their chains depend on
+This gives the OP Stack an unopinionated and flexible foundation, allowing chain operators to choose which chains the deployed chains depend on

Line range hint 89-93: Apply consistent capitalization to technical terms

Technical terms should maintain consistent capitalization. In the BeaconContract section, ensure consistent capitalization:

-BeaconProxies
+BeaconProxy contracts

Line range hint 103-107: Use Oxford comma consistently

Add Oxford comma in the list for consistency:

-Chain operators will need to run additional infrastructure to be part of the interoperable set. 
+Chain operators will need to run additional infrastructure to be part of the interoperable set:
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between d98652f and 02ea8e7.

📒 Files selected for processing (10)
  • .github/ISSUE_TEMPLATE/general_docs_request.md (1 hunks)
  • notes/nextra.md (1 hunks)
  • pages/500.mdx (1 hunks)
  • pages/builders/app-developers/bridging/messaging.mdx (1 hunks)
  • pages/builders/app-developers/transactions/estimates.mdx (1 hunks)
  • pages/builders/app-developers/transactions/troubleshooting.mdx (1 hunks)
  • pages/stack/components.mdx (1 hunks)
  • pages/stack/fault-proofs/explainer.mdx (1 hunks)
  • pages/stack/interop/explainer.mdx (1 hunks)
  • pages/stack/security/faq.mdx (1 hunks)
✅ Files skipped from review due to trivial changes (6)
  • pages/500.mdx
  • pages/builders/app-developers/bridging/messaging.mdx
  • pages/builders/app-developers/transactions/estimates.mdx
  • pages/builders/app-developers/transactions/troubleshooting.mdx
  • pages/stack/components.mdx
  • pages/stack/security/faq.mdx
🧰 Additional context used
📓 Path-based instructions (2)
pages/stack/fault-proofs/explainer.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
pages/stack/interop/explainer.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
🪛 LanguageTool
.github/ISSUE_TEMPLATE/general_docs_request.md

[uncategorized] ~12-~12: Possible missing comma found.
Context: ..., is the request related to an existing page or are you suggesting a brand-new docs ...

(AI_HYDRA_LEO_MISSING_COMMA)

🔇 Additional comments (4)
notes/nextra.md (2)

17-17: LGTM! Clear explanation of the MD5 hash requirement

The documentation clearly explains the technical requirement and its rationale, helping developers understand why MD5 content hashes are necessary for code imports.


17-17: Verify the referenced patch file

Let's ensure the referenced patch file exists and is accessible.

✅ Verification successful

Patch file exists and implements MD5 hash requirement correctly

The patch file exists and implements the stated functionality by:

  • Adding MD5 hash validation for imported code content
  • Requiring a hash= parameter with every code import
  • Verifying the provided hash matches the actual content hash
  • Providing helpful error messages that include the expected hash when validation fails
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the existence of the referenced patch file

# Check if the patch file exists
if [ -f "patches/[email protected]" ]; then
    echo "✓ Patch file exists"
    # Show first few lines of the patch to verify it's related to MD5 hash requirement
    head -n 5 "patches/[email protected]"
else
    echo "✗ Patch file not found at patches/[email protected]"
fi

Length of output: 346


Script:

#!/bin/bash
# Let's examine the full patch content to verify the MD5 hash requirement
cat patches/[email protected]

Length of output: 3119

pages/stack/fault-proofs/explainer.mdx (1)

95-95: LGTM: Correct hyphenation of "counter-claim"

The hyphenation is properly applied to the compound term.

pages/stack/interop/explainer.mdx (1)

36-36: Correct hyphenation of compound adjective

The hyphenation of "per-chain" is grammatically correct as it's used as a compound adjective modifying "basis".

@krofax krofax merged commit 8596c24 into ethereum-optimism:main Nov 27, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants