Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

holocene-changes: Update Sepolia MIPS address #1134

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

sebastianst
Copy link
Member

The existing MIPS was only useable for the devnet because testnet chains use a different preimage oracle. This new MIPS address uses the existing preimage oracle for Sepolia OP Chains.

The existing MIPS was only useable for the devnet because testnet chains use a different preimage oracle. This new MIPS address uses the existing preimage oracle for Sepolia OP Chains.
@sebastianst sebastianst requested a review from a team as a code owner November 22, 2024 03:46
Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit 0b13757
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/673ffe84f5823c0008182b1f
😎 Deploy Preview https://deploy-preview-1134--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Nov 22, 2024

📝 Walkthrough

Walkthrough

The pull request updates the document titled "Preparing for Holocene Breaking Changes" to provide detailed information about the Holocene network upgrade for chain and node operators. Key additions include a Callout section specifying the activation dates for the Holocene upgrade on the Sepolia and Mainnet Superchains. The document outlines three main changes associated with the upgrade: stricter block derivation rules, the ability to configure EIP-1559 parameters through the SystemConfig L1 contract, and updates to the MIPS contract to support new calls from the op-program version.

Instructions for chain operators emphasize the need to upgrade nodes before the activation dates and to update the SystemConfig to the latest release. The addresses for the updated SystemConfig implementations are included, and it is recommended to upgrade the SystemConfig after activation. The document also clarifies requirements for fault proof enabled chains and provides updated addresses for the MIPS contract in Sepolia. Node operators are instructed to upgrade specific versions of op-node and op-geth before the activation dates, with additional guidance for configuring the Holocene activation date.

Possibly related PRs

  • holocene upgrade notice page and docs updates #1108: This PR directly relates to the main PR as it focuses on the Holocene upgrade, providing documentation updates that align with the changes made in the main PR regarding the Holocene network upgrade for chain and node operators.

Suggested labels

do-not-merge

Suggested reviewers

  • sbvegan
  • cpengilly
  • ajsutton

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
pages/builders/notices/holocene-changes.mdx (2)

Line range hint 9-10: Improve clarity in the introduction

Consider revising to remove personal pronouns and use more direct language:

-This page outlines breaking changes related to the Holocene network upgrade for chain operators, and node operators.
-If you experience difficulty at any stage of this process, please reach out to [developer support](https://github.com/ethereum-optimism/developers/discussions).
+This documentation outlines Holocene network upgrade breaking changes for chain and node operators.
+For assistance with this process, contact [developer support](https://github.com/ethereum-optimism/developers/discussions).

Line range hint 12-17: Use consistent date formatting in the Callout

The date formats in the Callout section are inconsistent. Consider standardizing the format:

<Callout type="info">
-  The Holocene upgrade for the Sepolia Superchain will be activated at **Tue Nov 26 at 15:00:00 UTC** (`1732633200`).
+  The Holocene upgrade for the Sepolia Superchain activates on **2024-11-26 15:00:00 UTC** (`1732633200`).

-  The Holocene upgrade for the Mainnet Superchain is optimistically scheduled for **Thu 9 Jan 2025 18:00:01 UTC**, pending governance approval.
+  The Holocene upgrade for the Mainnet Superchain is optimistically scheduled for **2025-01-09 18:00:01 UTC**, pending governance approval.
</Callout>
📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 4bf7565 and 0b13757.

📒 Files selected for processing (1)
  • pages/builders/notices/holocene-changes.mdx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
pages/builders/notices/holocene-changes.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • For H1, H2, and H3 headers:
    1. Use sentence case, capitalizing only the first word.
    2. Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
    3. Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
  • Flag any headers that seem to inconsistently apply these rules for manual review.
  • When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
    "
🔇 Additional comments (1)
pages/builders/notices/holocene-changes.mdx (1)

47-47: Verify the new MIPS contract address deployment

The MIPS contract address for Sepolia has been updated. Let's verify this address is correct and deployed.

@cpengilly cpengilly merged commit 77a29ae into main Nov 22, 2024
8 of 9 checks passed
@cpengilly cpengilly deleted the seb/holocene-update-mips branch November 22, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants