-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
holocene-changes: Update Sepolia MIPS address #1134
Conversation
The existing MIPS was only useable for the devnet because testnet chains use a different preimage oracle. This new MIPS address uses the existing preimage oracle for Sepolia OP Chains.
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe pull request updates the document titled "Preparing for Holocene Breaking Changes" to provide detailed information about the Holocene network upgrade for chain and node operators. Key additions include a Callout section specifying the activation dates for the Holocene upgrade on the Sepolia and Mainnet Superchains. The document outlines three main changes associated with the upgrade: stricter block derivation rules, the ability to configure EIP-1559 parameters through the Instructions for chain operators emphasize the need to upgrade nodes before the activation dates and to update the Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
pages/builders/notices/holocene-changes.mdx (2)
Line range hint
9-10
: Improve clarity in the introductionConsider revising to remove personal pronouns and use more direct language:
-This page outlines breaking changes related to the Holocene network upgrade for chain operators, and node operators. -If you experience difficulty at any stage of this process, please reach out to [developer support](https://github.com/ethereum-optimism/developers/discussions). +This documentation outlines Holocene network upgrade breaking changes for chain and node operators. +For assistance with this process, contact [developer support](https://github.com/ethereum-optimism/developers/discussions).
Line range hint
12-17
: Use consistent date formatting in the CalloutThe date formats in the Callout section are inconsistent. Consider standardizing the format:
<Callout type="info"> - The Holocene upgrade for the Sepolia Superchain will be activated at **Tue Nov 26 at 15:00:00 UTC** (`1732633200`). + The Holocene upgrade for the Sepolia Superchain activates on **2024-11-26 15:00:00 UTC** (`1732633200`). - The Holocene upgrade for the Mainnet Superchain is optimistically scheduled for **Thu 9 Jan 2025 18:00:01 UTC**, pending governance approval. + The Holocene upgrade for the Mainnet Superchain is optimistically scheduled for **2025-01-09 18:00:01 UTC**, pending governance approval. </Callout>
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
pages/builders/notices/holocene-changes.mdx
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
pages/builders/notices/holocene-changes.mdx (1)
Pattern **/*.mdx
: "ALWAYS review Markdown content THOROUGHLY with the following criteria:
- Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
- Avoid gender-specific language and use the imperative form.
- Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
- Ensure proper nouns are capitalized in sentences.
- Apply the Oxford comma.
- Use proper title case for buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
- Use correct spelling and grammar at all times (IMPORTANT).
- For H1, H2, and H3 headers:
- Use sentence case, capitalizing only the first word.
- Preserve the capitalization of proper nouns, technical terms, and acronyms as defined in the 'nouns.txt' file located in the root directory of the project.
- Do not automatically lowercase words that appear in the 'nouns.txt' file, regardless of their position in the header.
- Flag any headers that seem to inconsistently apply these rules for manual review.
- When reviewing capitalization, always refer to the 'nouns.txt' file for the correct capitalization of proper nouns and technical terms specific to the project.
"
🔇 Additional comments (1)
pages/builders/notices/holocene-changes.mdx (1)
47-47
: Verify the new MIPS contract address deployment
The MIPS contract address for Sepolia has been updated. Let's verify this address is correct and deployed.
The existing MIPS was only useable for the devnet because testnet chains use a different preimage oracle. This new MIPS address uses the existing preimage oracle for Sepolia OP Chains.