-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: standard l2 genesis #97
Conversation
Add design doc
I am adding more information, thank you for the review so far |
Co-authored-by: Matt Solomon <[email protected]>
Here is a link to the audit plan for this feature: https://www.notion.so/oplabs/Isthmus-Smart-Contract-Audit-113f153ee16280448ebbd1b628c26ff2?pvs=4 |
Noticed something here: https://github.com/ethereum-optimism/optimism/blob/dcdf2b7693192f5bca0353bf22729f26c6240ea9/op-node/rollup/types.go#L43 The
I lean towards the second, it removes config overhead |
I think the second is doable so long as op-node can load it from the latest L1 block reliably. Otherwise it doesn't know which block the system config first existed in. In most cases (probably not all) op-node walks along L1 from the start block forwards loading data from the block its up to so it has a consistent view. This would need to be a case where it always goes to the latest value. The start block has to be immutable so that seems reasonable to me. |
Tracking the startblock config topic here: ethereum-optimism/optimism#12579 |
@maurelian Can I get an approval on this so we can merge? |
Description
Add design doc for standard L2 genesis
Tracking ticket: ethereum-optimism/optimism#12302