fixed cache issues on element index page #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for custom element types, Craft manages and invalidates element index cache on adding or editing an element. but for tag element, when you add or edit a tag via element index page or even tag field on entry page, Craft is not aware of this plugin's tag element type so this PR invalidate element type cache for this plugin on after save tag event
vnali
changed the title
|
Hmmm. This looks like it would work for Craft 4. |
|
can this be pulled and published? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #21 and #18
for custom element types, Craft manages and invalidates element index cache on adding or editing an element -i believe element index cache is related to 3.7.14-. but when you add or edit a tag via element index page or even tag field on entry page, Craft is not aware of this plugin's tag element type so this PR invalidate element type cache for this plugin on after save tag event