Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent Craft update causes no tags to be listed at /admin/tags #18

Closed
benatleith opened this issue Sep 13, 2021 · 10 comments · Fixed by #19
Closed

Recent Craft update causes no tags to be listed at /admin/tags #18

benatleith opened this issue Sep 13, 2021 · 10 comments · Fixed by #19
Assignees
Labels
bug Something isn't working

Comments

@benatleith
Copy link

Hi,

It appears that this recent Craft update has broken the list view:

craftcms/cms@636f778

When visiting /admin/tags no tags are listed (either when choosing 'All Tags' or when selecting a specific Tag Group)

Creating/editing tags works fine, it's just the list view which seems to be broken.

Craft version: 3.7.12
Plugin version: 1.0.7

@alexjcollins
Copy link
Member

@meestaben Right you are!

@Tam Could you pick this one up for me? Cheers!

@alexjcollins alexjcollins added the bug Something isn't working label Sep 13, 2021
@Reddogdesigns
Copy link

I'm also having this issue. Is there a rough timeline on when this might be resolved?

Thanks

@alanski66
Copy link

Had a quick look at fixing but couldn't quite work out what was missing - i think its missing a line in the db specifying what element type the tag.plugin is. Anyway I need to work around this and commenting out line 1440 here seems to provide a temporary work around

@stevecomrie
Copy link
Contributor

I've got a potential fix for this submitted as a pull request : #19

@CreateSean
Copy link

Having same issue

@alanski66
Copy link

alanski66 commented Sep 28, 2021

Quick solution is here: #19 (comment)
kudos to stevecomrie and meestaben for solving

@Tam Tam closed this as completed in cfc15a3 Oct 4, 2021
@benatleith
Copy link
Author

It appears that the Craft change that caused the breakage in the first place will be reversed in the next release:

craftcms/cms@509962a

@membla
Copy link

membla commented Jan 30, 2022

It appears that the Craft change that caused the breakage in the first place will be reversed in the next release:

craftcms/cms@509962a

Thought this was the reason for #21 but downgrading to 1.0.7 did not solve for me. Would be awesome with a new fix for this.

@alanski66
Copy link

NB it seems ordering by title makes tags appear for me

vnali added a commit to vnali/tags that referenced this issue Feb 12, 2022
for custom element types, Craft manages and invalidates element index cache on adding or editing an element. but for tag element, when you add or edit a tag via element index page or even tag field on entry page, Craft is not aware of this plugin's tag element type so this PR invalidate element type cache for this plugin on after save tag event
@markus-antoni
Copy link

For me on 3.7.36 it still (or again) doesn't work to see new added tags in /admin/tags. The count of tags is correct, but to see new added tag, I need to reorder or clear cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants