Skip to content

Commit

Permalink
Merge branch 'v3' of https://github.com/ethercreative/simplemap into v3
Browse files Browse the repository at this point in the history
  • Loading branch information
Tam committed Jan 30, 2018
2 parents 4c3b099 + fdb2332 commit 0bf70ba
Show file tree
Hide file tree
Showing 6 changed files with 51 additions and 7 deletions.
3 changes: 3 additions & 0 deletions .github/CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Code of Conduct

Don't be a twat.
32 changes: 32 additions & 0 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# Contributing

### New Features

You can request new features by submitting an issue with `[FR]` prefix in the title.

### Bugs

If you find a bug, submit an issue and I promise I will get around to it. Eventually.
Make sure you search around to see if the same (or similar) issue exists before
submitting a new one.

Know how to fix a bug and have too much spare time on your hands? Submit a Pull Request!
Check out the code conventions below before hand.

## Code Conventions

In addition to [Crafts Guidelines](https://github.com/craftcms/docs/blob/v3/en/coding-guidelines.md):

- Use tabs (4 spaces)
- Try to keep within the 80 characters line length
- If function arguments or array values can't fit on one line, break each value onto it's own line
- Comment as much as possible

#### JavaScript

In addition to the above:

- Write valid ES6
- Use double quotes `"`

Don't follow my example, try to stick to the above guidelines!
7 changes: 7 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Fixes # .

Changes proposed in this pull request:

-
-
-
9 changes: 5 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
## 3.2.0 - WIP
## 3.2.0 - 2018-01-25
### Fixed
- Not #70 yet
- Fixed bug where pagination would error when querying via a map field. #70

### Improved
- Updated CraftQL support (via @markhuot)
- Updated Mapbox example to use latest API
- Improved address and lat/lng input sizing on smaller screens and in a HUD
- Removed webonyx/graphql-php dependency #71
- Improved address and lat/lng input sizing on smaller screens and in a HUD #73
- Updated Mapbox example to use latest API #74

## 3.1.3 - 2017-12-18
### Fixed
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
![Simple Map](resources/banner.jpg)
![SimpleMap](resources/banner.jpg)

# Simple Map
# SimpleMap
A beautifully simple Google Map field type for **Craft 3**. Full localization support, compatible with Matrix & [CraftQL](https://github.com/markhuot/craftql), supports
searching by location and sorting by distance.

Expand Down
3 changes: 2 additions & 1 deletion src/services/MapService.php
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,8 @@ public function modifyElementsQuery (ElementQueryInterface $query, $value)
$this->_replaceOrderBy($query);
}

if (isset($oldOrderBy))
if (array_key_exists('oldOrderBy', get_defined_vars()))
/** @noinspection PhpUndefinedVariableInspection */
$query->orderBy = $oldOrderBy;

return;
Expand Down

0 comments on commit 0bf70ba

Please sign in to comment.