amend r-s

ethanzhouyc · Oct 17, 2024 · 86ec3af · 86ec3af
1 parent 0e165ae
commit 86ec3af
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 2 deletions.
diff --git a/src/app/zap-templates/zcl/data-model/chip/refrigerator-alarm.xml b/src/app/zap-templates/zcl/data-model/chip/refrigerator-alarm.xml
@@ -28,6 +28,7 @@ limitations under the License.
     <define>REFRIGERATOR_ALARM_CLUSTER</define>
     <client tick="false" init="false">true</client>
     <server tick="false" init="false">true</server>
+
     <attribute side="server" code="0x0000" define="MASK" type="AlarmBitmap" default="0">
       <description>Mask</description>
       <mandatoryConform/>

diff --git a/...ates/zcl/data-model/chip/refrigerator-and-temperature-controlled-cabinet-mode-cluster.xml b/...ates/zcl/data-model/chip/refrigerator-and-temperature-controlled-cabinet-mode-cluster.xml
@@ -66,6 +66,7 @@ limitations under the License.
     </attribute>
     <attribute side="server" code="0x0002" define="START_UP_MODE"    type="int8u"                              writable="true"  optional="true"  isNullable="true">StartUpMode</attribute>
     <attribute side="server" code="0x0003" define="ON_MODE"          type="int8u"                              writable="true"  optional="true"  isNullable="true">OnMode</attribute>
+
     <!-- Commands -->
     <command source="client" code="0x00" name="ChangeToMode" response="ChangeToModeResponse" optional="false">
       <description>

diff --git a/src/app/zap-templates/zcl/data-model/chip/resource-monitoring-cluster.xml b/src/app/zap-templates/zcl/data-model/chip/resource-monitoring-cluster.xml
@@ -68,6 +68,7 @@ limitations under the License.
         <feature name="REP"/>
       </mandatoryConform>
     </attribute>
+
     <!-- Commands -->
     <command source="client" code="0x00" name="ResetCondition" optional="true">
       <description>Reset the condition of the replaceable to the non degraded state</description>
@@ -127,6 +128,7 @@ limitations under the License.
         <feature name="REP"/>
       </mandatoryConform>
     </attribute>
+
     <!-- Commands -->
     <command source="client" code="0x00" name="ResetCondition" optional="true">
       <description>Reset the condition of the replaceable to the non degraded state</description>

diff --git a/src/app/zap-templates/zcl/data-model/chip/scene.xml b/src/app/zap-templates/zcl/data-model/chip/scene.xml
@@ -92,6 +92,7 @@ limitations under the License.
       <description>FabricSceneInfo</description>
       <mandatoryConform/>
     </attribute>
+
     <command source="client" code="0x00" name="AddScene" response="AddSceneResponse" isFabricScoped="true" optional="false" cli="chip scenes add">
       <description>
         Add a scene to the scene table. Extension field sets are supported, and are inputed as '{"ClusterID": VALUE, "AttributeValueList":[{"AttributeID": VALUE, "Value*": VALUE}]}'

diff --git a/src/app/zap-templates/zcl/data-model/chip/service-area-cluster.xml b/src/app/zap-templates/zcl/data-model/chip/service-area-cluster.xml
@@ -125,6 +125,7 @@ limitations under the License.
         <feature name="PROG"/>
       </mandatoryConform>
     </attribute>
+
     <!-- Commands -->
     <command source="client" code="0x00" name="SelectAreas" response="SelectAreasResponse" optional="false">
       <description>

diff --git a/src/app/zap-templates/zcl/data-model/chip/smoke-co-alarm-cluster.xml b/src/app/zap-templates/zcl/data-model/chip/smoke-co-alarm-cluster.xml
@@ -107,6 +107,7 @@ limitations under the License.
       <description>ExpiryDate</description>
       <optionalConform/>
     </attribute>
+
     <!-- Commands -->
     <command source="client" code="0x00" name="SelfTestRequest" optional="true">
       <description>This command SHALL initiate a device self-test.</description>

diff --git a/src/app/zap-templates/zcl/data-model/chip/software-diagnostics-cluster.xml b/src/app/zap-templates/zcl/data-model/chip/software-diagnostics-cluster.xml
@@ -36,6 +36,7 @@ limitations under the License.
         <optionalConform/>
       </feature>
     </features>
+
     <attribute side="server" code="0x00" define="THREAD_METRICS" type="array" entryType="ThreadMetricsStruct" length="254" optional="true">
       <description>ThreadMetrics</description>
       <optionalConform/>
@@ -68,7 +69,6 @@ limitations under the License.
       <field id="2" name="FaultRecording" type="octet_string" length="1024" optional="true"/>
       <optionalConform/>
     </event>
-
   </cluster>
 
 </configurator>
diff --git a/src/app/zap-templates/zcl/data-model/chip/switch-cluster.xml b/src/app/zap-templates/zcl/data-model/chip/switch-cluster.xml
@@ -77,11 +77,12 @@ Interactions with the switch device are exposed as attributes (for the latching
         </optionalConform>
       </feature>
     </features>
+
     <attribute side="server" code="0x0000" define="NUMBER_OF_POSITIONS" type="int8u" default="2" min="2">
       <description>NumberOfPositions</description>
       <mandatoryConform/>
     </attribute>
-    <attribute side="server" code="0x0001" define="CURRENT_POSITION" type="int8u">
+    <attribute side="server" code="0x0001" define="CURRENT_POSITION" type="int8u" reportable="true">
       <description>CurrentPosition</description>
       <mandatoryConform/>
     </attribute>