Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AA-430: (WIP) Encode 'UsedGasBreakdown' struct for 'postPaymasterTx' frame #45

Open
wants to merge 2 commits into
base: RIP-7560-revision-2
Choose a base branch
from

Conversation

forshtat
Copy link

No description provided.

Copy link

@drortirosh drortirosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think that this breakdown is "too much information". It dumps internal gas breakdown to the paymaster.
Paymaster are now required to use a helper method to sum/sub all params.

  • paymaster are now "incentivized" to use this breakdown information - but that makes them even more exposed to internal impl:
    • (e.g 7702 is never "installed", and paid by "preTx" rather than "deployment")
    • erc-4337 is here to stay for a long time on mainnet, and we can't add it to 4337. Thus Paymasters that support these features are incompatible by definition (and such price differences are much more relevant on L1 than on L2..)

OTOH, this breakdown is not even enough:

  • actual breakdown of execution (or even validation) to "modules" and "target contract" is unavailable (technically, we can't)
  • paymaster is given the breakdown - but only after the TX. neither account nor paymaster are given the breakdown prior the TX (during validation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants