-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AA-428: New JSON-RPC API ERC #11
Conversation
ERCS/erc-4337-rpc.md
Outdated
|
||
#### eth_sendUserOperation | ||
|
||
The `eth_sendUserOperation` method submits a `UserOperation` object to the UserOperation mempool of the client. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't use the term "client": it is very confusing and nowdays incorrect (stem from the days where each user was expected to run a node, and thus a node is a "client" - which is no longer true)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the of the client
part as it adds no value to the sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
client
is still used all over the place, instead of bundler
,
In order to facilitate the operation of the alternative `UserOperation` mempool it is important that all | ||
implementations of the ERC-4337 protocol have a standardized set of APIs that can be used interchangeably. | ||
|
||
## Specification |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing "definitions" section.
- bundler a node exposing the APIs, in order to submit them to the network. A bundler collects one or more UserOperations into a bundle and submits them together to the EntryPoint in a single
handleUserOp
call
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(a bundler is a logical entity, handling UserOps. it MAY be part of a "client", or not)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the "definitions" section and a definition for "bundler". If there are further definitions you would like to add, please do.
Closed in favour of ethereum#628 |
The commit f310120 (as a parent of 4b7f972) contains errors. |
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: