Clear clipboard of the mnemonic #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yorickdowne
requested review from
valefar-on-discord and
remyroy
as code owners
yorickdowne
force-pushed
the
clear-clipboard
branch
from
2405c0b to
d4106aa
Compare
|
Test Coverage: Download HTML Report |
remyroy
requested changes
Sep 6, 2024
There was a problem hiding this comment.
This should be documented in:
- https://github.com/eth-educators/ethstaker-deposit-cli/blob/main/docs/src/new_mnemonic.md
- https://github.com/eth-educators/ethstaker-deposit-cli/blob/main/docs/src/existing_mnemonic.md
and probably on the CLI help and on the user screen when performing the task with something along the lines of We will attempt to clear your clipboard after confirming your mnemonic so make sure to write it down somewhere safe first..
yorickdowne
force-pushed
the
clear-clipboard
branch
from
d4106aa to
bce3e69
Compare
|
Added a warning (and a note in docs) for |
|
Test Coverage: Download HTML Report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #32
Changes
Use
pyperclip, which works on macOS, Linux and Windows, to set the clipboard to a space character after user is done inputting dataTypes of changes
What types of changes does your code introduce?
Testing
Requires testing
Remarks
This introduces some host dependencies. Notably on Linux, clipboard mechanisms only exist if a window manager is present. So as to not bomb out on headless Linux, the code is in a
try: except:"On Windows, no additional modules are needed.
On Mac, this module makes use of the pbcopy and pbpaste commands, which should come with the os.
On Linux, this module makes use of the xclip or xsel commands, which should come with the os. Otherwise run “sudo apt-get install xclip” or “sudo apt-get install xsel” (Note: xsel does not always seem to work.)"