Add MEV Boost prompt to validator only setup and remove unused code #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haurog
changed the title
haurog
changed the title
|
Too aggressive, noninteractive is in use |
|
If you hang loose, I am about to merge something that removes the unused vars. Maybe you can change this PR to be just the MEV boost change then |
|
I will wait and change my PR after you merged. |
|
That's merged, Go ahead and remove conflicts with ethd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow my second commit, which is unrelated to the unused code discussion got added to this PR as well.
The first commit is related to:
Fixes #1491
Apparently my second commit (MEV Boost related) got automatically added to this PR. The idea is that in the case of a validator only setup one has to manually edit the .env file to be able to use a pre-configured MEV Boost on the remote client. This is quite easy to miss and therefore I added an additional prompt to the config CLI UI. I tested it in various combinations manually and it worked in all cases.