Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge GET requests to /tasks,/compute/jobs and /compute/acct in the async client #73

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Merge GET requests to /tasks,/compute/jobs and /compute/acct in the async client #73

merged 3 commits into from
Oct 2, 2023

Conversation

ekouts
Copy link
Collaborator

@ekouts ekouts commented Sep 28, 2023

Two important differences in this PR:

  • All the tasks methods call the /tasks endpoint with the tasks param, instead of /tasks/<taskid>.
  • The async client will hold a set of taksids and try to merge the requests that are made to the /tasks endpoint, when possible.
  • Requests are merged for the poll and poll-active methods.

@ekouts ekouts self-assigned this Sep 28, 2023
@ekouts ekouts changed the title Merge GET requests to /tasks,/compute/jobs and /compute/acct, when possible in the async client Merge GET requests to /tasks,/compute/jobs and /compute/acct in the async client Sep 28, 2023
@ekouts ekouts requested a review from rsarm October 2, 2023 07:27
jpdorsch
jpdorsch approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@jpdorsch jpdorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ekouts ekouts merged commit efbf60b into eth-cscs:main Oct 2, 2023
5 checks passed
@ekouts ekouts deleted the request_merging branch October 2, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpdorsch jpdorsch jpdorsch approved these changes

@rsarm rsarm Awaiting requested review from rsarm

Assignees

@ekouts ekouts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ekouts @jpdorsch