Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend compress and extract functions to handle large directories #109

Merged
merged 22 commits into from
Jun 19, 2024
Merged

Extend compress and extract functions to handle large directories #109

merged 22 commits into from
Jun 19, 2024

Conversation

ekouts
Copy link
Collaborator

@ekouts ekouts commented Jun 4, 2024

No description provided.

@ekouts
wip
f598e05
@ekouts
wip
34b1e38
@ekouts
Merge branch 'main' of github.com:eth-cscs/pyfirecrest into refactor/…
96292a5 
…async_merge_reqs
@ekouts
Add timers in async client
76d210b
@ekouts
Stash
8314c84
@ekouts
Don't merge reqs by default
01c5048
@ekouts
Bring back the old merge_request
28018d1
@ekouts
Fix internal dictionaries keys
a4019e2
@ekouts
Move decorator to wrapper GET function
375bd81
@ekouts
Merge branch 'main' of github.com:eth-cscs/pyfirecrest into refactor/…
3951eee 
…async_merge_reqs
@ekouts
Fix tasks endpoint in reference
1dd06e5
@ekouts
Extend compress func in basic client
24f2a7d
@ekouts
Extend compress func in basic client
030ec1f
@ekouts
Merge branch 'main' of github.com:eth-cscs/pyfirecrest into refactor/…
4a4b87d 
…async_merge_reqs
@ekouts
Merge branch 'refactor/async_merge_reqs' of github.com:ekouts/pyfirec…
6ea526b 
…rest-fork into feat/extend_compress_and_extract
@ekouts
Extend compress and extract func in async client
00f9e05
@ekouts ekouts self-assigned this Jun 4, 2024
@ekouts ekouts marked this pull request as draft June 4, 2024 10:02
khsrali
khsrali suggested changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@khsrali khsrali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ekouts thanks for this useful changes.
I made some comments. Notice in AsyncClient, I only checked compress&extract haven't check changes of @_retry_requests which thought might be from the other PR.

firecrest/BasicClient.py Show resolved Hide resolved
firecrest/BasicClient.py Outdated Show resolved Hide resolved
firecrest/BasicClient.py Show resolved Hide resolved
firecrest/BasicClient.py Show resolved Hide resolved
firecrest/BasicClient.py Outdated Show resolved Hide resolved
firecrest/AsyncClient.py Show resolved Hide resolved
firecrest/AsyncClient.py Outdated Show resolved Hide resolved
firecrest/AsyncClient.py Show resolved Hide resolved
firecrest/AsyncClient.py Show resolved Hide resolved
firecrest/AsyncClient.py Show resolved Hide resolved
@ekouts ekouts marked this pull request as ready for review June 14, 2024 12:48
@ekouts ekouts requested a review from khsrali June 14, 2024 12:49
@ekouts ekouts mentioned this pull request Jun 14, 2024
Merged
@ekouts ekouts requested review from jpdorsch and removed request for khsrali and jpdorsch June 17, 2024 12:57
theely
theely approved these changes Jun 18, 2024
View reviewed changes
firecrest/AsyncClient.py Outdated Show resolved Hide resolved
firecrest/AsyncClient.py Outdated Show resolved Hide resolved
firecrest/AsyncClient.py Show resolved Hide resolved
firecrest/AsyncClient.py Show resolved Hide resolved
firecrest/AsyncClient.py Outdated Show resolved Hide resolved
firecrest/BasicClient.py Outdated Show resolved Hide resolved
firecrest/BasicClient.py Outdated Show resolved Hide resolved
firecrest/BasicClient.py Outdated Show resolved Hide resolved
firecrest/BasicClient.py Show resolved Hide resolved
firecrest/BasicClient.py Show resolved Hide resolved
@ekouts ekouts merged commit 0cfdc3e into eth-cscs:main Jun 19, 2024
8 checks passed
@ekouts ekouts deleted the feat/extend_compress_and_extract branch June 24, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theely theely theely approved these changes

@khsrali khsrali khsrali requested changes

Assignees

@ekouts ekouts

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ekouts @theely @khsrali