Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation #8

Draft
wants to merge 45 commits into
base: main
Choose a base branch
from
Draft

Add documentation #8

wants to merge 45 commits into from

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented May 22, 2024

  • Close Add documentation #7
  • Add GitHub Action to automatically deploy documentation on the gh-pages branch

Documentation Preview

The documentation is currently incomplete: only one function per algorithm is documented, plus the helper functions. It will be completed once the phrasing is agreed upon.

@RMeli RMeli added the documentation Improvements or additions to documentation label May 22, 2024
@RMeli RMeli self-assigned this May 22, 2024
.github/workflows/docs.yaml Outdated Show resolved Hide resolved
DLA-Future-Fortran.md Outdated Show resolved Hide resolved
@rasolca
Copy link
Collaborator

rasolca commented May 24, 2024

Preliminary questions:
Is the doc already available somewhere?
Any plan to keep the documentation of released versions?

@RMeli
Copy link
Member Author

RMeli commented May 24, 2024

Is the doc already available somewhere?

There is a preview from my fork: https://rmeli.github.io/DLA-Future-Fortran

Any plan to keep the documentation of released versions?

Not really... I'm open to suggestions.

DLA-Future-Fortran.md Outdated Show resolved Hide resolved
@RMeli RMeli marked this pull request as ready for review May 24, 2024 10:34
@RMeli RMeli marked this pull request as draft May 24, 2024 10:58
DLA-Future-Fortran.md Outdated Show resolved Hide resolved
src/dlaf_fortran.f90 Outdated Show resolved Hide resolved
Copy link
Collaborator

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the looks of it.

DOCUMENTATION.md Outdated Show resolved Hide resolved
DOCUMENTATION.md Outdated Show resolved Hide resolved
@RMeli
Copy link
Member Author

RMeli commented Jul 10, 2024

I created an orphan docs-ghpages branch, made it a protected branch, and set it as the deployment branch for GitHub Pages.

Documentation for my fork is now available at https://rmeli.github.io/DLA-Future-Fortran/main/

Copy link
Member Author

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I incorporated all comments (also from offline) and added wording for the _factorized generalised eigensolver. Please have one more look at the current look and wording: https://rmeli.github.io/DLA-Future-Fortran/main/index.html

If this is OK, I'll add the same documentation to all functions.

push:
branches:
- main
- '**' # TODO: Remove when done testing!
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be removed before merging.

Comment on lines +41 to +42
#if: "github.repository == 'eth-cscs/DLA-Future-Fortran' && github.ref == 'refs/heads/main'"
if: "github.repository == 'RMeli/DLA-Future-Fortran'"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix before merging.

Copy link
Collaborator

@rasolca rasolca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation
4 participants