fix: publish_source with crossing remmapings #1551
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
In projects with overlapping remappings publish_source returns an error:
FileNotFoundError: [Errno 2] No such file or directory: '/Users/user/.brownie/packages/OpenZeppelin/[email protected]/contracts/token/ERC1155/IERC1155Upgradeable.sol'
The remap_import function checks the match in any order.
How I did it
Sorted the list remappings by length in descending order, which allowed to exclude the crossing like openzeppelin in openzeppelin-upgradeable.
How to verify it
I could not find suitable tests for this part of the functionality. For check, it is necessary to pass verification with the configuration specified above.
Checklist