Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMakeList for Windows build and CI test #74

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

TheTechsTech
Copy link

Great work!

I had a different vector construction setup, then came across your feature for regular array index access. I scraped/refactored my version in https://github.com/zelang-dev/c-raii/tree/main/src/vector.c to use yours exclusively, memory usage cleanup is automatic though, RAII.

There are a few ideas to make c-vector more expandable, like adding an enum type field to vector_metadata_t, macro to set/get.

@eteran
Copy link
Owner

eteran commented Dec 22, 2024

I'll take a look in a little bit! Thanks

@eteran
Copy link
Owner

eteran commented Dec 23, 2024

This generally looks good. Just as a heads up, another PR that also at least touches CMakeLists.txt came in literally just the day before you submitted yours. So we may need to rebase yours and resolve conflicts after I merge his. (Calling it a night tonight, but will probably try to merge both the other PR and yours tomorrow).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants