tracker: track in-flight commit index #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@serathius Can I ask you to review this too? CRDB reviewers are OOO this week. |
pav-kv
force-pushed
the
track-inflight-commit
branch
from
e8365b4 to
055a4d4
Compare
ahrtr
reviewed
Feb 27, 2024
pav-kv
force-pushed
the
track-inflight-commit
branch
2 times, most recently
from
02ac83b to
0611757
Compare
|
@serathius Could you take a look please? |
Yes, it's definitely better to have a second review for any behaviour or logic change. We need to minimize any risk as much as possible. For any mechanical change, such as just renaming or simple code refactor, it's OK to merge with only one approval. Such as #172
It's in my to-do list. Will take a look later. |
bdarnell
reviewed
Feb 29, 2024
|
@serathius ping |
erikgrinaker
reviewed
Mar 4, 2024
pav-kv
force-pushed
the
track-inflight-commit
branch
2 times, most recently
from
7e87703 to
0611757
Compare
erikgrinaker
approved these changes
Mar 6, 2024
pav-kv
force-pushed
the
track-inflight-commit
branch
from
0611757 to
508fcce
Compare
pav-kv
force-pushed
the
track-inflight-commit
branch
from
508fcce to
8b05a9d
Compare
ahrtr
reviewed
Mar 7, 2024
|
Please also rebase this PR to resolve the workflow failure. |
When we send a snapshot, this is equivalent to sending all entries up to the snapshot's index. Correspondingly, we update the Next index to reflect this in-flight state. Signed-off-by: Pavel Kalinnikov <[email protected]>
This commit adds a Progress.pendingCommit field tracking the highest commit index <= Next-1 which the leader sent to the follower. It is used to distinguish cases when a commit index update needs or doesn't need to be sent to a follower. Signed-off-by: Pavel Kalinnikov <[email protected]>
Signed-off-by: Pavel Kalinnikov <[email protected]>
pav-kv
force-pushed
the
track-inflight-commit
branch
from
8b05a9d to
0f9fe52
Compare
|
@ahrtr done |
ahrtr
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a
Progress.sentCommitfield tracking the highest commit index which the leader sent to the follower. It is used to distinguish cases when a commit index update needs or doesn't need to be sent to a follower.Touches #131