Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: simplify mod tidy pass #19042

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Dec 11, 2024

The original go mod tidy pass implementation was done before the --diff go mod option existed. This simplifies the implementation, as temporary files are no longer needed.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

The original go mod tidy pass implementation was done before the `--diff`
go mod option existed. This simplifies the implementation, as temporary
files are no longer needed.

Signed-off-by: Ivan Valdes <[email protected]>
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.68%. Comparing base (3cf550d) to head (9d8f2fa).
Report is 4 commits behind head on main.

Additional details and impacted files

see 17 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19042      +/-   ##
==========================================
- Coverage   68.75%   68.68%   -0.08%     
==========================================
  Files         420      420              
  Lines       35623    35623              
==========================================
- Hits        24493    24467      -26     
- Misses       9709     9727      +18     
- Partials     1421     1429       +8     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cf550d...9d8f2fa. Read the comment docs.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the cleanup.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit f03dee9 into etcd-io:main Dec 12, 2024
35 checks passed
@ivanvc ivanvc deleted the update-go-mod-tidy-pass-to-use-diff branch December 12, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants